Fail loud when the report's reference adopter is unresolvable - #392
Merged
Conversation
In --report mode, an unresolvable reference adopter (a mistyped name) made manifest_gap_pass return no slug and an empty gaps list, and the report was written anyway - its empty gap section reading as a false clean. Validate the reference adopter up front (before the fleet sweep) and exit non-zero with a clear message instead. Fails in 0.04s on a typo rather than after a full sweep. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens spec/fidelity_honesty.py --report so a mistyped/unresolvable reference adopter fails fast and does not write a misleading (false-clean) report.
Changes:
- Adds an up-front registry lookup in
--reportmode to ensure the reference adopter exists before running the fleet sweep. - Emits a clear stderr error and exits non-zero when the adopter is not found, avoiding writing an empty/incorrect report.
Uh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a Copilot finding on the develop→main promotion (#391): in
fidelity_honesty.py --reportmode, an unresolvable reference adopter (a mistyped name) mademanifest_gap_passreturn no slug and an empty gaps list, and the report was written anyway — its empty gap section reading as a false clean.Validate the reference adopter up front (before the fleet sweep) and exit non-zero with a clear message. Fails in ~0.04s on a typo instead of after a full sweep. The report output for a valid adopter is unchanged.
Verification
python3 spec/fidelity_honesty.py --report NoSuchRepo123→ prints the error and exits 1 in 0.04s, writes nothing;spec/validate.pygreen.🤖 Generated with Claude Code