Conversation
Two backlog items from the HA/ESPHome convergence: (1) standardize `OPERATIONS.md` as the fleet's extraction target for operational content pulled out of a carried AGENTS.md (both repos' agents converged on it); (2) add a canonical clang-format config for the `cpp` type - the C++ analogue of the shared ruff config - so `cpp.clangformat.shared` references one style, based on the ESPHome agent's proposal. Docs-only. `spec/validate.py` OK. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Codifies the fix for a race an agent (me) hit: the merge gate required a review on the current head SHA, but nothing warned that a push makes required checks go green **before** the re-review lands - so a poll that reads `mergeStateStatus` first sees `CLEAN` in that window and exits ready before Copilot has reviewed the head. ## Changes - **AGENTS.md Merge Gate** (verbatim, provider-independent): precondition 2 names the race and requires matching the review's commit SHA to the head, stating a green merge-state can precede the current-head review and never signals readiness on its own. - **copilot-instructions.md runbook**: a note in "Verify Review Covered Current Head" - gate on a formal review whose `commit.oid` equals the head first, then zero unresolved threads, and only then read merge-state. Re-vendors fleet-wide. `spec/validate.py` OK. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
The tracked follow-up to the type-model work: CODESTYLE described the two Python profiles as Project/Scripts, while project-types.json now names the declared profiles `build`/`lint-only` (with Project/Scripts as the structural pyproject shapes). Bridge them - each shape bullet now names its declared profile (Project = `build`, Scripts = `lint-only`) - so the vocabulary is consistent across the two docs. Also splits a pre-existing semicolon in the Project bullet. Carried doc (intent), re-vendors fleet-wide. `spec/validate.py` OK. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes the develop-branch documentation updates to main by extending the backlog, aligning Python profile terminology in CODESTYLE with the spec’s build/lint-only vocabulary, and explicitly documenting the post-push “checks green before review lands” race in the merge gate/runbook guidance.
Changes:
- Add backlog items to standardize
OPERATIONS.mdas the operational-doc extraction target and to define a fleet-standard clang-format configuration for thecpptype. - Update CODESTYLE’s Python section to map Project/Scripts shapes to the declared
build/lint-onlyprofile names. - Strengthen merge-gate and runbook guidance to require confirming Copilot review coverage on the current head SHA before relying on merge-state.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Adds two new backlog entries for OPERATIONS.md standardization and a shared clang-format config. |
| CODESTYLE.md | Bridges Python “Project/Scripts” shapes to the declared build/lint-only profile names used by the type model. |
| AGENTS.md | Updates the merge gate to explicitly call out and guard against the post-push review/merge-state race. |
| .github/copilot-instructions.md | Adds a concrete instruction to check head-SHA review coverage before reading mergeStateStatus. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote develop to main
Three doc/spec-only changes (no code path, no release):
OPERATIONS.mdas the extraction target for operational content, and add a canonical clang-format config for thecpptype.build/lint-onlynames.Verification
spec/validate.pyOK;spec/audit.py --selftestPASS.🤖 Generated with Claude Code