Skip to content

Add set -euo pipefail to multi-line workflow run blocks#68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptr727 merged 1 commit into from
May 11, 2026
Merged

Add set -euo pipefail to multi-line workflow run blocks #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build-nugetlibrary-task.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,6 +39,7 @@ jobs:

- name: Build NuGet library project step
run: |
set -euo pipefail
dotnet build ./NuGetLibrary/NuGetLibrary.csproj \
-property:OutputPath=${{ runner.temp }}/publish/ \
-property:PackageOutputPath=${{ runner.temp }}/publish/ \
Expand All@@ -52,6 +53,7 @@ jobs:
- name: Publish to NuGet.org step
if: ${{ inputs.push }}
run: |
set -euo pipefail
dotnet nuget push ${{ runner.temp }}/publish/*.nupkg \
--source https://api.nuget.org/v3/index.json \
--api-key ${{ secrets.NUGET_API_KEY }} \
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/run-codegen-app-pull-request-task.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,12 +43,14 @@ jobs:

- name: Run codegen step
run: |
set -euo pipefail
dotnet run --project ./CodeGen/CodeGen.csproj -- \
--codepath ./CodeGen \
--apikey "${{ secrets.NINJA_API_KEY }}"

- name: Format code step
run: |
set -euo pipefail
dotnet tool restore
dotnet csharpier format --log-level=debug .
git status
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/run-codegen-pull-request-task.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,12 +33,14 @@ jobs:

- name: Run codegen step
run: |
set -euo pipefail
dotnet run --project ./CodeGen/CodeGen.csproj -- \
--codepath ./CodeGen \
--apikey "${{ secrets.NINJA_API_KEY }}"

- name: Format code step
run: |
set -euo pipefail
dotnet tool restore
dotnet csharpier format --log-level=debug .
git status
Expand All@@ -60,6 +62,7 @@ jobs:
- name: Trigger PR workflows step
if: steps.cpr.outputs.pull-request-number != ''
run: |
set -euo pipefail
PR="${{ steps.cpr.outputs.pull-request-number }}"
gh pr close "$PR"
gh pr reopen "$PR"
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-pull-request.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ jobs:
steps:
- name: Check workflow results step
run: |
set -euo pipefail
exit_on_result() {
if [[ "$2" == "failure" || "$2" == "cancelled" ]]; then
echo "Job '$1' failed or was cancelled."
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,8 +8,8 @@
.artifacts
.DS_Store
*.user
.claude

# Python / uv
__pycache__/
*.py[cod]
*.egg-info/
Expand Down
Loading