Skip to content

Fix README bullet formatting and correct PyPI publish action SHA - #69

Merged
ptr727 merged 1 commit into
developfrom
pr66-followups-readme-pypi
May 11, 2026
Merged

Fix README bullet formatting and correct PyPI publish action SHA#69
ptr727 merged 1 commit into
developfrom
pr66-followups-readme-pypi

Conversation

@ptr727

Copy link
Copy Markdown
Owner

Summary

Two follow-ups for PR #66 (the active developmain release PR):

1. README.md — missing colons on NuGet/PyPI bullets

Copilot review thread on PR #66 flagged that the NuGet and PyPI bullets in the Build and Distribution list are missing the colon after the bold label that every other bullet in the list uses.

- - **NuGet Packages** [NuGet Packages][nuget-link] - .NET libraries published to NuGet.org.- - **PyPI Packages** [PyPI Packages][pypi-link] - Python library published to PyPI.org.+ - **NuGet Packages**: [NuGet Packages][nuget-link] - .NET libraries published to NuGet.org.+ - **PyPI Packages**: [PyPI Packages][pypi-link] - Python library published to PyPI.org.

2. publish-release.yml — wrong SHA for pypa/gh-action-pypi-publish@v1.14.0

The action was pinned to SHA 6733eb7d741f0b11ec6a39b58540dab7590f9b7d with a # v1.14.0 comment, but the upstream v1.14.0 tag actually points at cef221092ed1bacb1cc03d23a2d87d1d172e277b. Because ghcr.io/pypa/gh-action-pypi-publish is tagged by release SHAs, no GHCR image existed at the wrong SHA — Docker bailed out with manifest unknown.

This has caused Publish PyPI library job to fail on every push to develop since PR #64 added the action. CI evidence:

Fix: use the actual upstream v1.14.0 SHA, keep the # v1.14.0 comment.

Why a new PR (not committed onto PR #66's branch)

Standing project rule: no direct commits to develop. Once this PR merges to develop, PR #66's diff absorbs both fixes automatically (since #66 is developmain), and the README Copilot thread on #66 can be resolved.

Test plan

Two follow-ups for PR #66:
- README.md: add the missing colon after the bold label on the NuGet
and PyPI Build-and-Distribution bullets, matching the format of the
Source Code / Versioned Releases / Docker Images bullets above.
(Copilot review thread on PR #66.)
- .github/workflows/publish-release.yml: correct the pinned SHA for
pypa/gh-action-pypi-publish@v1.14.0 from 6733eb7d... to cef22109...
The previous SHA didn't match the upstream v1.14.0 tag, so GHCR had
no image at that ref and the docker-action invocation failed with
"manifest unknown" on every push to develop since PR #64. The new
SHA matches upstream v1.14.0.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CopilotAI review requested due to automatic review settings May 11, 2026 15:35

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies two small follow-ups to keep documentation formatting consistent and to fix a broken GitHub Actions release publish path for the Python package.

Changes:

  • Fix Markdown list formatting consistency by adding missing colons after the bold labels for the NuGet and PyPI bullets in the README.
  • Correct the pinned commit SHA for pypa/gh-action-pypi-publish in publish-release.yml (while retaining the # v1.14.0 annotation), addressing the invalid image reference issue.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

FileDescription
README.mdAdds missing colons to match the established “Label:” bullet style in Build and Distribution.
.github/workflows/publish-release.ymlUpdates the pinned pypa/gh-action-pypi-publish commit SHA so the publish step can resolve the intended release artifact.

@ptr727
ptr727 merged commit 79b34e0 into developMay 11, 2026
25 checks passed
@ptr727
ptr727 deleted the pr66-followups-readme-pypi branch July 7, 2026 21:05
@ptr727ptr727 mentioned this pull request Aug 18, 2026
ptr727 added a commit that referenced this pull request Aug 18, 2026
## Summary
- state where downstream agents run every `scripts/pr_review.py` command
- clarify that the review helper is hub-hosted and never carried
- regenerate the Copilot and Claude skill distributions
## Why
PhotoCleaner PR #69 exposed that the numbered review loop could be read
independently from its closing mechanics section. In a downstream
repository, the unqualified command then points at a script that
correctly does not exist there.
## Verification
- full `OPERATIONS.md` local verification chain
- 727 unit tests plus audit and write-guard self-tests
- generated skill distribution consistency
- repository and prose gates
- JSON and spec validation
- editorconfig-checker, ShellCheck, and PSScriptAnalyzer
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: ptr727-codegen[bot] <275599072+ptr727-codegen[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ptr727ptr727 mentioned this pull request Aug 18, 2026
ptr727 added a commit that referenced this pull request Aug 18, 2026
## Summary
- promote the current `develop` branch to `main`
- release the clarified hub-checkout requirement for the review helper
- unblock the corrected carried skill in PhotoCleaner PR #69
## Verification
- #817 passed the full local verification chain and all required checks
- Copilot reviewed the current #817 head and full diff with no findings
@ptr727ptr727 mentioned this pull request Aug 18, 2026
ptr727 added a commit that referenced this pull request Aug 18, 2026
## Summary
- combine the review wait command and its terminal-outcome guidance into
one procedure step
- renumber the remaining review-loop steps
- regenerate the Copilot and Claude skill distributions
## Why
PhotoCleaner PR #69 exposed that two adjacent numbered steps both
instructed the reader to wait. The second was explanatory text for the
first, but its numbering made the procedure look like two separate
waits.
## Verification
- full `OPERATIONS.md` local verification chain
- 727 unit tests plus audit and write-guard self-tests
- generated skill distribution consistency
- repository and prose gates
- JSON and spec validation
- editorconfig-checker, ShellCheck, and PSScriptAnalyzer
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: ptr727-codegen[bot] <275599072+ptr727-codegen[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ptr727ptr727 mentioned this pull request Aug 18, 2026
ptr727 added a commit that referenced this pull request Aug 18, 2026
## Summary
- promote the current `develop` branch to `main`
- release the unambiguous single-step review wait procedure
- unblock the final carried-skill review fix in PhotoCleaner PR #69
## Verification
- #819 passed the full local verification chain and all required checks
- Copilot reviewed the current #819 head and full diff with no findings
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727