Skip to content

Clarify Default Action Validation - #795

Merged
ptr727 merged 2 commits into
developfrom
feature/correct-validation-doc
Aug 17, 2026
Merged

Clarify Default Action Validation#795
ptr727 merged 2 commits into
developfrom
feature/correct-validation-doc

Conversation

@ptr727

Copy link
Copy Markdown
Owner

Summary

Correct the reusable-workflow guide's description of default-action input validation.

Why

The late suppressed review on #792 correctly identified that the guide assigned validation to build-release-task.yml. Each selected hub default action performs that validation instead. Caller-provided hooks remain free to use different inputs.

Validation

  • Diff-scoped prose lint
  • markdownlint, 120 files
  • Ruff lint and format checks
  • mypy
  • Repository gate
  • EditorConfig checker
  • git diff --check

CopilotAI lite review requested due to automatic review settings August 17, 2026 18:30

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the reusable-workflow guide to accurately describe where default-action input validation occurs, aligning the documentation with how the hub defaults behave.

Changes:

  • Correct the description of project-path validation so it is attributed to the selected hub default actions rather than build-release-task.yml.
  • Clarify that caller-provided hooks can continue to use their own input shapes without matching hub defaults.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment threaddocs/reusable-workflows.md Outdated
CopilotAI review requested due to automatic review settings August 17, 2026 18:32

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@ptr727
ptr727 merged commit 1d1eb1c into developAug 17, 2026
8 checks passed
@ptr727ptr727 mentioned this pull request Aug 17, 2026
ptr727 added a commit that referenced this pull request Aug 17, 2026
## Summary
Promote the reviewed validation-documentation correction from `develop`
to `main`.
## Included Change
- State that each selected default action validates its own required
inputs.
- Keep caller-provided hooks independent of default-action input
contracts.
## Validation
- Feature PR #795 completed 7/7 checks.
- Copilot reviewed the exact feature head with full diff coverage.
- The single inline finding was fixed, answered, and resolved.
This promotion does not publish a release.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727