Skip to content

Make PR Review Monitoring the Default - #814

Merged
ptr727 merged 2 commits into
developfrom
feature/pr-lifecycle-default
Aug 18, 2026
Merged

Make PR Review Monitoring the Default#814
ptr727 merged 2 commits into
developfrom
feature/pr-lifecycle-default

Conversation

@ptr727

Copy link
Copy Markdown
Owner

Summary

  • Make pull request creation start the review loop by default.
  • Require a foreground review status read followed by a bounded background wait.
  • Continue through findings, fixes, replies, resolution, and re-review until green.
  • Permit stopping or altering the loop only on explicit maintainer instruction.
  • Expand the skill trigger and AGENTS routing so the rule fires when a PR opens.
  • Regenerate the GitHub Copilot and Claude Code skill distributions.

Why

The review-loop procedure was correct after it started, but neither the skill trigger nor the PR-creation handoff required it to start. An agent could therefore open a draft PR, report the URL, and stop before requesting or monitoring review.

Verification

  • uvx coverage@latest run --source=scripts,spec,host-setup -m unittest discover -s scripts/tests (727 tests passed)
  • python3 scripts/tests/test_build_dist.py (25 tests passed)
  • python3 scripts/build_dist.py --check
  • Diff-scoped prose and sentence-length checks
  • EOL and diff checks
  • markdownlint-cli2 (158 files, 0 issues)

CopilotAI lite review requested due to automatic review settings August 18, 2026 17:50

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the fleet PR review-loop contract so that opening a pull request explicitly starts (and does not end) the default review-monitoring loop, requiring an initial foreground status read followed by a bounded background wait, and propagates that rule through the skill distributions.

Changes:

  • Updated GOVERNANCE.md PR Review Etiquette to state that PR creation starts the review loop and that the loop must be actively monitored by default.
  • Expanded AGENTS.md routing so the PR review conduct rule is triggered when opening a pull request.
  • Updated and re-distributed the pr-review-conduct skill content across the Copilot/agents/Claude skill trees, including the regenerated source digest.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
GOVERNANCE.mdClarifies the default PR review-loop contract starts at PR open and requires active monitoring until green.
AGENTS.mdUpdates the routing table so pr-review-conduct applies when opening a PR as well as monitoring/closing reviews.
.github/skills/pr-review-conduct/SKILL.mdUpdates the skill trigger text and expected loop steps (foreground status, bounded background wait).
.agents/skills/pr-review-conduct/SKILL.mdMirrors the updated pr-review-conduct skill content for the agents skill distribution.
.claude-plugin/fleet-skills/skills/pr-review-conduct/SKILL.mdMirrors the updated pr-review-conduct skill content for the Claude plugin distribution.
.claude-plugin/fleet-skills/.source-digestUpdates the plugin source digest to match the regenerated skill distribution.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

CopilotAI review requested due to automatic review settings August 18, 2026 18:24

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

@ptr727
ptr727 marked this pull request as ready for review August 18, 2026 18:27
@ptr727
ptr727 merged commit cfc29ce into developAug 18, 2026
8 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727