Make PR Review Monitoring the Default - #814
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the fleet PR review-loop contract so that opening a pull request explicitly starts (and does not end) the default review-monitoring loop, requiring an initial foreground status read followed by a bounded background wait, and propagates that rule through the skill distributions.
Changes:
- Updated
GOVERNANCE.mdPR Review Etiquette to state that PR creation starts the review loop and that the loop must be actively monitored by default. - Expanded
AGENTS.mdrouting so the PR review conduct rule is triggered when opening a pull request. - Updated and re-distributed the
pr-review-conductskill content across the Copilot/agents/Claude skill trees, including the regenerated source digest.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| GOVERNANCE.md | Clarifies the default PR review-loop contract starts at PR open and requires active monitoring until green. |
| AGENTS.md | Updates the routing table so pr-review-conduct applies when opening a PR as well as monitoring/closing reviews. |
| .github/skills/pr-review-conduct/SKILL.md | Updates the skill trigger text and expected loop steps (foreground status, bounded background wait). |
| .agents/skills/pr-review-conduct/SKILL.md | Mirrors the updated pr-review-conduct skill content for the agents skill distribution. |
| .claude-plugin/fleet-skills/skills/pr-review-conduct/SKILL.md | Mirrors the updated pr-review-conduct skill content for the Claude plugin distribution. |
| .claude-plugin/fleet-skills/.source-digest | Updates the plugin source digest to match the regenerated skill distribution. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ptr727
marked this pull request as ready for review
August 18, 2026 18:27
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The review-loop procedure was correct after it started, but neither the skill trigger nor the PR-creation handoff required it to start. An agent could therefore open a draft PR, report the URL, and stop before requesting or monitoring review.
Verification
uvx coverage@latest run --source=scripts,spec,host-setup -m unittest discover -s scripts/tests(727 tests passed)python3 scripts/tests/test_build_dist.py(25 tests passed)python3 scripts/build_dist.py --check