Skip to content

Address Promotion Review Findings - #823

Merged
ptr727 merged 2 commits into
developfrom
feature/promotion-review-fixes
Aug 18, 2026
Merged

Address Promotion Review Findings#823
ptr727 merged 2 commits into
developfrom
feature/promotion-review-fixes

Conversation

@ptr727

Copy link
Copy Markdown
Owner

Summary

  • Keep the devcontainer uv warm-up limited to locked Python projects and run it frozen.
  • Correct the workflow snippet catalog description of hub-hosted tasks.
  • Complete the PyPI caller example with consume-then-delete cleanup and its permission.

Context

Addresses all three review findings raised on promotion PR #822.

Verification

  • Full repository Python, spec, repo, Markdown, workflow, and shell gates
  • 727 unit tests
  • Diff and prose checks

Co-authored-by: OpenAI Codex <codex@openai.com>
CopilotAI lite review requested due to automatic review settings August 18, 2026 22:02

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses the promotion-review follow-ups by tightening the devcontainer uv warm-up behavior, correcting the workflow snippet catalog description, and completing the PyPI caller example with artifact cleanup after publish.

Changes:

  • Gate the devcontainer uv warm-up to locked Python projects by requiring uv.lock, and run uv sync in frozen mode.
  • Update the workflow snippet catalog description to reflect that the hub .github/workflows/ contains both entry points and reusable tasks.
  • Extend the PyPI publish caller example to delete the consumed build artifact and add the required actions: write permission.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

FileDescription
docs/reusable-workflows.mdAdds actions: write and a post-publish artifact deletion step to the PyPI caller example.
catalog/snippets/workflows/README.mdCorrects the description of where reusable workflow tasks live and how the snippet table is scoped.
catalog/snippets/devcontainer/python/post-create.shLimits uv warm-up to projects with uv.lock and runs uv sync with --frozen.
Suppressed comments (1)

docs/reusable-workflows.md:534

  • Agent-authored prose convention prohibits mid-sentence semicolons (see .agents/skills/comment-and-doc-style/SKILL.md:171-173). This warning message uses a semicolon, which will violate that convention in any lint that checks emitted/logged prose.
 echo "::warning::Failed to delete artifact $id; retention-days backstop will reap it."

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment threaddocs/reusable-workflows.md Outdated
Co-authored-by: OpenAI Codex <codex@openai.com>
CopilotAI review requested due to automatic review settings August 18, 2026 22:05
@ptr727

Copy link
Copy Markdown
OwnerAuthor

Addressed the one suppressed finding from 85ce8c3 in b1ffb83. The warning for a failed artifact deletion now uses two sentences instead of a mid-sentence semicolon; the sibling artifact-listing warning was corrected in the same commit.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@ptr727
ptr727 merged commit bfda2b0 into developAug 18, 2026
8 checks passed
@ptr727
ptr727 deleted the feature/promotion-review-fixes branch August 18, 2026 22:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727