Address Promotion Review Findings - #823
Merged
Merged
Conversation
Co-authored-by: OpenAI Codex <codex@openai.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses the promotion-review follow-ups by tightening the devcontainer uv warm-up behavior, correcting the workflow snippet catalog description, and completing the PyPI caller example with artifact cleanup after publish.
Changes:
- Gate the devcontainer uv warm-up to locked Python projects by requiring
uv.lock, and runuv syncin frozen mode. - Update the workflow snippet catalog description to reflect that the hub
.github/workflows/contains both entry points and reusable tasks. - Extend the PyPI publish caller example to delete the consumed build artifact and add the required
actions: writepermission.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/reusable-workflows.md | Adds actions: write and a post-publish artifact deletion step to the PyPI caller example. |
| catalog/snippets/workflows/README.md | Corrects the description of where reusable workflow tasks live and how the snippet table is scoped. |
| catalog/snippets/devcontainer/python/post-create.sh | Limits uv warm-up to projects with uv.lock and runs uv sync with --frozen. |
Suppressed comments (1)
docs/reusable-workflows.md:534
- Agent-authored prose convention prohibits mid-sentence semicolons (see .agents/skills/comment-and-doc-style/SKILL.md:171-173). This warning message uses a semicolon, which will violate that convention in any lint that checks emitted/logged prose.
echo "::warning::Failed to delete artifact $id; retention-days backstop will reap it."
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: OpenAI Codex <codex@openai.com>
ptr727
commented
Aug 18, 2026
OwnerAuthor
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Addresses all three review findings raised on promotion PR #822.
Verification