Conversation
## Summary - Treat missing `copilot_work_started` as inconclusive for effort-labeled reviews. - Report effective Lite, Balanced, or Max metadata without changing user settings. - Keep the deprecated pickup option compatible and update the review contracts and tests. ## Verification - 729 Python tests - ruff lint and format - mypy - distribution, prose, repository, spec, and diff gates - Docker editorconfig-checker, ShellCheck, and PSScriptAnalyzer - live status read against PR #873 Related to #868.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates scripts/pr_review.py and its surrounding guidance/tests to treat Copilot “review effort” as an observed metadata field (Lite/Balanced/Max), while no longer using missing copilot_work_started telemetry as evidence of a stalled request.
Changes:
- Add parsing/reporting of
Review effort levelfrom completed head reviews and emiteffort/effort_sourcein the digest output. - Remove the “request not picked up” (timeline-based) classification and keep pending requests as
PENDINGuntil timeout/review/answer. - Align documentation and skills guidance with the new effort and pending-request semantics, and update regression tests accordingly.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/pr_review.py | Implements effort parsing/reporting and removes timeline-based “picked up” stall detection. |
| scripts/tests/test_pr_review.py | Updates/expands unit coverage for effort parsing and revised wait behavior. |
| scripts/README.md | Updates operational documentation to match the new pending/effort semantics. |
| .github/skills/pr-review-conduct/SKILL.md | Adds effort-level guidance to the PR review conduct skill. |
| .agents/skills/pr-review-conduct/SKILL.md | Mirrors the same effort-level guidance for agent skill distribution. |
| .claude-plugin/fleet-skills/skills/pr-review-conduct/SKILL.md | Mirrors the same effort-level guidance for the Claude plugin skill distribution. |
| .claude-plugin/fleet-skills/.source-digest | Updates the source digest to reflect the regenerated skill payload. |
| .github/copilot-instructions.md | Notes effort as user-controlled and that missing copilot_work_started is inconclusive. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
## Summary - Document the bounded-wait behavior after `PENDING requested=yes`. - Continue waiting by default because missing pickup telemetry is inconclusive. - Reserve review-request replacement for a maintainer-directed retry without changing effort settings. ## Verification - 730 Python tests - distribution, prose, repository, and diff gates - Docker editorconfig-checker, ShellCheck, and PSScriptAnalyzer Addresses the finding on promotion PR #877.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copilot_work_startedas inconclusive for effort-labeled reviews.Verification
Closes#868.