Conversation
## Summary - Ignore carriage-return-only differences when scoping prose findings. - Cover EOL renormalization and genuine content edits with a Git-backed regression test. - Identify repo-config paths as hub-hosted in the workflow skill reference. Addresses #869 and #870. ## Verification - ruff check and format check - mypy - 731 Python unit tests with 79% aggregate coverage - build distribution, repository, prose, JSON, and spec gates The executor's Docker daemon could not expose the worktree to the read-only container mounts, so the editorconfig-checker, ShellCheck, and PSScriptAnalyzer container gates were unavailable locally.
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes the develop-branch fixes for the prose-gate diff scoping and branch-protection skill documentation into main, so EOL-only renormalization commits no longer explode the prose scope and repo-config references consistently reflect the hub-hosted model.
Changes:
- Update
prose_lint.changed_lines()to ignore CR-at-EOL differences when computing changed-line scope. - Add a Git-backed regression test covering EOL-only edits vs real content edits.
- Update the operational-vs-release-workflow “branch protection and promotion” reference text (and its generated mirrors) to consistently describe
repo-config/as hub-hosted.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/tests/test_prose_lint.py | Adds a regression test ensuring CRLF→LF-only changes produce an empty diff scope while real edits still scope correctly. |
| .github/actions/prose-gate/prose_lint.py | Adjusts the underlying git diff invocation to ignore CR-at-EOL-only differences. |
| .github/skills/operational-vs-release-workflow/references/branch-protection-and-promotion.md | Updates documentation to reference hub-hosted repo-config/ paths consistently. |
| .agents/skills/operational-vs-release-workflow/references/branch-protection-and-promotion.md | Mirrors the same documentation update in the agent skill distribution. |
| .claude-plugin/fleet-skills/skills/operational-vs-release-workflow/references/branch-protection-and-promotion.md | Mirrors the same documentation update in the Claude plugin skill distribution. |
| .claude-plugin/fleet-skills/.source-digest | Updates the plugin source digest to reflect the mirrored content change. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promote the reviewed prose-gate and workflow-skill fixes from develop.
Closes#869.
Closes#870.
Included Pull Requests