- Notifications
You must be signed in to change notification settings - Fork 0
Promote Develop to Main#921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -44,6 +44,19 @@ | ||
| - **Use modern syntax**: `list[int]` not `List[int]`, `dict[str, X]` not `Dict[str, X]`, | ||
| `X | None` not `Optional[X]`, `from __future__ import annotations` only when needed for forward | ||
| references. | ||
| - **Don't hedge that syntax for an older interpreter.** `pyproject.toml` pins `target-version` / | ||
| `python_version` to 3.13 for every Python profile in this repo, and `spec/host-tools.json` | ||
| carries that as the host floor `scripts/host_gate.py` enforces, so 3.10+-only syntax (`X | None`, | ||
| `match`, etc.) needs no quoting, no `typing.Union` fallback, and no `from __future__ import | ||
| annotations` guard on that account alone. Add that import only when a real forward reference | ||
| needs it, per the bullet above. Three named exceptions carry a lower floor on purpose and say so | ||
| themselves: `scripts/skills_install.sh` and the `install-skills.*` bootstrap scripts, which must | ||
| run on whatever interpreter a host already has before this floor's toolchain exists to install | ||
| one, and `spec/resolve_description.py`, which `repo-config/configure.sh`'s own bootstrap probe | ||
| accepts down to 3.7 for the same reason, and which carries `from __future__ import annotations` | ||
| for exactly that purpose rather than out of habit. No other `spec/` code has a reason to hedge, | ||
| so that import or a quoted annotation appearing anywhere else in `spec/` is a sign this one | ||
| exception got copied rather than a pattern to follow. | ||
coderabbitai[bot] marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| - **Don't add `# type: ignore` to silence pyright errors without a comment** explaining the | ||
| constraint. If a recurring false positive needs suppression, configure it project-wide in | ||
| `[tool.pyright]`. A new port doesn't change this, fix freshly surfaced type errors rather than | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 716018234e006002 | ||
| 598e6a55149a7fde |
13 changes: 13 additions & 0 deletions
13 .claude-plugin/fleet-skills/skills/python-codestyle/references/code-style.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -44,6 +44,19 @@ | ||
| - **Use modern syntax**: `list[int]` not `List[int]`, `dict[str, X]` not `Dict[str, X]`, | ||
| `X | None` not `Optional[X]`, `from __future__ import annotations` only when needed for forward | ||
| references. | ||
| - **Don't hedge that syntax for an older interpreter.** `pyproject.toml` pins `target-version` / | ||
| `python_version` to 3.13 for every Python profile in this repo, and `spec/host-tools.json` | ||
| carries that as the host floor `scripts/host_gate.py` enforces, so 3.10+-only syntax (`X | None`, | ||
| `match`, etc.) needs no quoting, no `typing.Union` fallback, and no `from __future__ import | ||
| annotations` guard on that account alone. Add that import only when a real forward reference | ||
| needs it, per the bullet above. Three named exceptions carry a lower floor on purpose and say so | ||
| themselves: `scripts/skills_install.sh` and the `install-skills.*` bootstrap scripts, which must | ||
| run on whatever interpreter a host already has before this floor's toolchain exists to install | ||
| one, and `spec/resolve_description.py`, which `repo-config/configure.sh`'s own bootstrap probe | ||
| accepts down to 3.7 for the same reason, and which carries `from __future__ import annotations` | ||
| for exactly that purpose rather than out of habit. No other `spec/` code has a reason to hedge, | ||
| so that import or a quoted annotation appearing anywhere else in `spec/` is a sign this one | ||
| exception got copied rather than a pattern to follow. | ||
ptr727 marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| - **Don't add `# type: ignore` to silence pyright errors without a comment** explaining the | ||
| constraint. If a recurring false positive needs suppression, configure it project-wide in | ||
| `[tool.pyright]`. A new port doesn't change this, fix freshly surfaced type errors rather than | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -44,6 +44,19 @@ | ||
| - **Use modern syntax**: `list[int]` not `List[int]`, `dict[str, X]` not `Dict[str, X]`, | ||
| `X | None` not `Optional[X]`, `from __future__ import annotations` only when needed for forward | ||
| references. | ||
| - **Don't hedge that syntax for an older interpreter.** `pyproject.toml` pins `target-version` / | ||
| `python_version` to 3.13 for every Python profile in this repo, and `spec/host-tools.json` | ||
| carries that as the host floor `scripts/host_gate.py` enforces, so 3.10+-only syntax (`X | None`, | ||
| `match`, etc.) needs no quoting, no `typing.Union` fallback, and no `from __future__ import | ||
| annotations` guard on that account alone. Add that import only when a real forward reference | ||
| needs it, per the bullet above. Three named exceptions carry a lower floor on purpose and say so | ||
| themselves: `scripts/skills_install.sh` and the `install-skills.*` bootstrap scripts, which must | ||
| run on whatever interpreter a host already has before this floor's toolchain exists to install | ||
| one, and `spec/resolve_description.py`, which `repo-config/configure.sh`'s own bootstrap probe | ||
| accepts down to 3.7 for the same reason, and which carries `from __future__ import annotations` | ||
| for exactly that purpose rather than out of habit. No other `spec/` code has a reason to hedge, | ||
| so that import or a quoted annotation appearing anywhere else in `spec/` is a sign this one | ||
| exception got copied rather than a pattern to follow. | ||
ptr727 marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| - **Don't add `# type: ignore` to silence pyright errors without a comment** explaining the | ||
| constraint. If a recurring false positive needs suppression, configure it project-wide in | ||
| `[tool.pyright]`. A new port doesn't change this, fix freshly surfaced type errors rather than | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -70,13 +70,16 @@ description="" | ||
| if [ -f "$registry" ]; then | ||
| # Resolved here, not near the top, so a run with no registry (an explicit model, no hub checkout) never needs Python at all. | ||
| # The name python3 is not universal: native Windows can register a Microsoft Store stub under that name that resolves on PATH but fails when actually run, so this runs it rather than just checking PATH (docs/host-setup.md). | ||
| # The probe itself is spec/resolve_description.py's actual floor (PEP 563, Python 3.7+) rather than an arbitrary version number, so a too-old interpreter fails here with a clear message instead of a bare SyntaxError from the script. | ||
| # The probe checks 3.7+ (PEP 563, from __future__ import annotations) because that is the oldest interpreter resolve_description.py happens to parse and run on, not because 3.7 is this repo's supported floor. | ||
| # The repository floor is 3.13 (spec/host-tools.json's python3 target, enforced on the host by scripts/host_gate.py). | ||
| # Its own from __future__ import annotations is what lets resolve_description.py stay parseable below that, not a license for any other spec/ code to hedge for anything older. | ||
| # A too-old interpreter fails here with a clear message instead of a bare traceback from the script. | ||
| if python3 -c "from __future__ import annotations" >/dev/null 2>&1; then | ||
| py_cmd=(python3) | ||
| elif py -3 -c "from __future__ import annotations" >/dev/null 2>&1; then | ||
| py_cmd=(py -3) | ||
| else | ||
| echo "No Python 3.7+ interpreter found (python3 or py -3). See docs/host-setup.md." >&2 | ||
| echo "No Python interpreter found (python3 or py -3) able to run resolve_description.py. This repo targets Python 3.13 (see docs/host-setup.md)." >&2 | ||
| exit 1 | ||
ptr727 marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| fi | ||
| # Delegates to spec/resolve_description.py rather than a third hand-rolled copy of description_errors(). | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.