Skip to content

Ignore mypy Cache Directory - #968

Merged
ptr727 merged 1 commit into
developfrom
feature/mypy-cache-gitignore
Aug 24, 2026
Merged

Ignore mypy Cache Directory#968
ptr727 merged 1 commit into
developfrom
feature/mypy-cache-gitignore

Conversation

@ptr727

@ptr727ptr727 commented Aug 24, 2026

Copy link
Copy Markdown
Owner

Every other Python tool cache (.pytest_cache, .ruff_cache, .pyright) was already ignored, but .mypy_cache was not, so a local mypy run left the checkout looking dirty. Verified: mypy creates it in the repo root by default, and it now shows as ignored rather than untracked.

Summary by CodeRabbit

  • Chores
    • Updated repository configuration to ignore Python type-checking cache files.

Every other Python tool cache (.pytest_cache, .ruff_cache, .pyright) was already ignored, but .mypy_cache was not, so a local mypy run left the checkout looking dirty. Verified: mypy creates it in the repo root by default, and it now shows as ignored rather than untracked.
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Ignore mypy cache directory in gitignore

⚙️ Configuration changes🕐 Less than 5 minutes

Grey Divider

AI Description

• Add .mypy_cache/ to .gitignore to avoid dirty working trees after mypy runs.
Diagram

graph TD
Dev[Developer] --> Git["git status"] --> Ignore[".gitignore"] --> Cache[".mypy_cache/"]
subgraph Legend
direction LR
_p[Process/User] ~~~ _f[File/Config] ~~~ _d[(Generated Dir)]
end
Loading
High-Level Assessment

Current approach is optimal: ignore the tool-generated .mypy_cache/ directory at the repo root, consistent with existing ignores for other Python tool caches.

Files changed (1) +1 / -0

Other (1) +1 / -0
.gitignoreIgnore mypy cache directory+1/-0

Ignore mypy cache directory

• Adds .mypy_cache/ to the ignored paths so mypy runs do not leave untracked files in the repository.

.gitignore

@coderabbitai

coderabbitaiBot commented Aug 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4164481c-e04a-4b5e-a4cf-c7b858ed5111

📥 Commits

Reviewing files that changed from the base of the PR and between 75b90b1 and 54c1d27.

📒 Files selected for processing (1)
  • .gitignore

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The repository ignore rules now exclude the .mypy_cache/ directory generated by mypy.

Changes

Python tooling hygiene

Layer / File(s)Summary
Ignore mypy cache files
.gitignore
Adds .mypy_cache/ to the ignored Python tooling cache directories.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk:⚪ Minimal · up to 54c1d

This localized change prevents the mypy cache from appearing as untracked repository content; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the change to ignore the .mypy_cache directory.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/mypy-cache-gitignore

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0)📘 Rule violations (0)📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can switch off images and animations for a plain-text comment

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@ptr727
ptr727 merged commit 7b77f68 into developAug 24, 2026
8 checks passed
@ptr727
ptr727 deleted the feature/mypy-cache-gitignore branch August 24, 2026 03:51
@ptr727ptr727 mentioned this pull request Aug 24, 2026
ptr727 added a commit that referenced this pull request Aug 24, 2026
## Included
- #968 — Ignore mypy cache directory (.gitignore).
- #969 — Detect Copilot account-quota exhaustion in `pr_review.py`'s
`wait`/`status`
(distinct refusal cause, repo-wide silent-exhaustion short-circuit,
`--ignore-quota-signal` override), plus a generic identity-level
generalization of thread-resolution tracking, head-presence, and
rate-limit-marker detection to cover CodeRabbit and Qodo alongside
Copilot.
## Testing
Both source PRs were driven through full review loops (Qodo +
CodeRabbit,
Copilot quota-exhausted throughout) and merged clean. 272 tests, ruff,
ruff-format, mypy, and prose_lint all pass on develop's current head.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Added tracking for CodeRabbit, qodo, and Copilot review activity.
- Review status now includes unresolved threads, rate limits, quota
exhaustion, and per-reviewer results.
- The workflow can automatically request reviews and identify
repository-wide Copilot quota limits.
- Added an option to ignore Copilot quota signals while waiting for
results.
- **Bug Fixes**
- Improved handling of missing thread authors and generic review
refusals.
- Prioritizes pull-request-specific outcomes over broader repository
signals.
- Improved reviewer attribution and status reporting across review
history.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@ptr727