Fix Broken Troubleshooting Snippet in ssh-signing.md - #976
Conversation
The 'signing failed: no allowed signers' troubleshooting line paraphrased the setup snippet with an unquoted, truncated 'echo ... >> ...' form. Copied literally, the shell strips the quotes around "git" (writing namespaces=git instead of namespaces="git") and the truncated destination path is not a real command. Use the exact, complete command from the setup section instead. Found by CodeRabbit and Qodo reviewing PR #975 (docs/ssh-signing.md:117).
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe SSH signing troubleshooting command now uses escaped quoting and the complete ChangesSSH signing documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk:⚪ Minimal · up to This is a narrowly scoped documentation fix that restores the complete, correctly quoted troubleshooting command; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
PR Summary by QodoFix broken troubleshooting command in ssh-signing.md
AI Description
High-Level Assessment
Files changed (1) |
Code Review by Qodo
1. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
PR #975 (the develop -> main promotion PR) surfaced this against #974's change: the
"signing failed: no allowed signers" troubleshooting line paraphrased the setup
snippet as an unquoted, truncated
echo ... >> ...form. Copied literally, a shellstrips the quotes around
"git"(writingnamespaces=gitinstead ofnamespaces="git"), and the truncated destination path isn't a real command.Both CodeRabbit and Qodo flagged this independently on PR #975. Fix: use the exact,
complete command from the setup section (matching line 35) instead of paraphrasing it.
🤖 Generated with Claude Code
Summary by CodeRabbit