Conversation
Bumps csharpier from 1.1.1 to 1.1.2 Bumps xunit.analyzers from 1.23.0 to 1.24.0 Bumps xunit.runner.visualstudio from 3.1.3 to 3.1.4 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.1.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: xunit.analyzers dependency-version: 1.24.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: xunit.runner.visualstudio dependency-version: 3.1.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com>
…op/nuget-deps-0259308462 Bump the nuget-deps group with 3 updates
Bumps xunit.runner.visualstudio from 3.1.4 to 3.1.5 --- updated-dependencies: - dependency-name: xunit.runner.visualstudio dependency-version: 3.1.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com>
…evelop/nuget-deps-6aadeae1b1 Bump the nuget-deps group with 1 update
--- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com>
…op/nuget-deps-39349b7924 Bump csharpier from 1.1.2 to 1.2.1
--- updated-dependencies: - dependency-name: Serilog.Sinks.Console dependency-version: 6.1.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com>
…nuget-deps-602f419b37 Bump Serilog.Sinks.Console from 6.0.0 to 6.1.1
Bumps csharpier from 1.2.1 to 1.2.3 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com>
…op/nuget-deps-1689e99d0a Bump the nuget-deps group with 1 update
Bumps the actions-deps group with 2 updates in the / directory: [actions/setup-dotnet](https://github.com/actions/setup-dotnet) and [actions/checkout](https://github.com/actions/checkout). Updates `actions/setup-dotnet` from 4 to 5 - [Release notes](https://github.com/actions/setup-dotnet/releases) - [Commits](actions/setup-dotnet@v4...v5) Updates `actions/checkout` from 5 to 6 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-dotnet dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps csharpier from 1.2.3 to 1.2.4 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com>
…op/nuget-deps-133b2bc611 Bump the nuget-deps group with 1 update
Bumps csharpier from 1.2.4 to 1.2.5 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com>
…op/nuget-deps-262ca43251 Bump the nuget-deps group with 1 update
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the utilities library to .NET 10 with AOT support and removes the ProcessEx class. The changes include extensive async method additions, comprehensive XML documentation, and updated test coverage. However, the PR contains critical compilation errors in Extensions.cs that must be fixed before merging.
Key Changes:
- Upgraded target framework from .NET 9 to .NET 10 with AOT support
- Removed ProcessEx class (users should migrate to CliWrap)
- Added async versions of file operations, downloads, and compression methods with proper cancellation token support
- Added comprehensive XML documentation to all public APIs
- Replaced old solution file format with new .slnx format
Reviewed changes
Copilot reviewed 28 out of 29 changed files in this pull request and generated 26 comments.
Show a summary per file
| File | Description |
|---|---|
| version.json | Version bumped from 3.3 to 3.4 |
| UtilitiesTests/UtilitiesTests.csproj | Updated to .NET 10, added analysis settings, upgraded package versions |
| UtilitiesTests/*.cs | Added comprehensive test coverage for new functionality (StringHistory, async compression, async file operations, downloads, console utilities) |
| Utilities/Utilities.csproj | Upgraded to .NET 10 with AOT support, enabled nullable reference types, added documentation generation, Husky integration |
| Utilities/StringHistory.cs | Added XML documentation and null validation |
| Utilities/StringCompression.cs | Added async methods, compression level support, and comprehensive documentation |
| Utilities/ProcessEx.cs | Removed entirely (breaking change) |
| Utilities/LogOptions.cs | Added XML documentation |
| Utilities/Format.cs | Added XML documentation, improved BytesToKilo implementation with switch expression |
| Utilities/FileExOptions.cs | Added XML documentation |
| Utilities/FileEx.cs | Added async versions of all file operations, removed MethodBase parameter from logging, added comprehensive documentation |
| Utilities/Extensions.cs | CRITICAL: Contains invalid syntax - uses non-existent extension keyword |
| Utilities/Download.cs | Refactored to use Lazy, added async methods, increased timeout to 180s, added comprehensive documentation |
| Utilities/ConsoleEx.cs | Added XML documentation, improved null handling |
| Utilities/CommandLineEx.cs | Added XML documentation, improved argument parsing |
| Utilities.slnx | New solution file format replacing Utilities.sln |
| Utilities.sln | Removed (replaced by .slnx) |
| Sandbox/Sandbox.csproj | Updated to .NET 10 with AOT support |
| Sandbox/Program.cs | Fixed nullable reference handling |
| README.md | Updated version history |
| .husky/task-runner.json | Removed IDE0055 diagnostic exclusion |
| .github/workflows/BuildPublishPipeline.yml | Updated actions versions, changed to .NET 10 |
| .github/copilot-instructions.md | New comprehensive development guidelines (contains incorrect information about extension keyword) |
| .config/dotnet-tools.json | Updated CSharpier to 1.2.5 and Husky to 0.8.0 |
Comments suppressed due to low confidence (1)
UtilitiesTests/UtilitiesTests.csproj:26
- The package version "18.0.1" for Microsoft.NET.Test.Sdk may not exist. As of January 2025, the latest stable version is 17.x. Please verify this version exists on NuGet before using it.
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| ConsoleEx.WriteLineColor(color, "Test"); | ||
| // Reset console | ||
| StreamWriter standardOutput = new(Console.OpenStandardOutput()) { AutoFlush = true }; |
There was a problem hiding this comment.
Disposable 'StreamWriter' is created but not disposed.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Contributor
7 tasks
Contributor
5 tasks
Contributor
5 tasks
Contributor
7 tasks
Contributor
5 tasks
* Initial plan * Make HttpClient timeout configurable via TimeoutSeconds property Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Initial plan * Replace redundant ToString() with string interpolation in FileExAsyncTests --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
* Initial plan * Replace explicit ToString() calls with string interpolation Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 29 out of 31 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
Utilities/Download.cs:227
- The HttpClient timeout was changed from 30 seconds to 180 seconds (3 minutes). This is a significant change that could impact application behavior. Consider whether this change is intentional and if it should be configurable rather than hardcoded, especially for a library where different consumers may have different timeout requirements.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Contributor
5 tasks
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.