') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Spell out the up-to-date ruleset setting in the 5D audit summary by ptr727 · Pull Request #425 · ptr727/Utilities · GitHub
Skip to content

Spell out the up-to-date ruleset setting in the 5D audit summary - #425

Merged
ptr727 merged 2 commits into
developfrom
docs/strict-off-terminology
Jul 18, 2026
Merged

Spell out the up-to-date ruleset setting in the 5D audit summary#425
ptr727 merged 2 commits into
developfrom
docs/strict-off-terminology

Conversation

@ptr727

Copy link
Copy Markdown
Owner

Closes the terminology nit Copilot raised on #423, which I deferred there as out of scope for that promotion.

strict-off appeared exactly once in WORKFLOW.md (the 5D audit summary). Section 6 spells the same setting out twice:

  • main: "require branches up to date before merging" is **off**
  • develop: "up to date" is **off**

The summary now uses the section 6 phrasing, so both places name the setting identically.

The word "strict" survives at line 646 (so the strict check would fail every release), which is correct -- that sentence is explaining why the setting is off, and "the strict check" is GitHub's own term for the behavior.

Docs-only; no shipped input, so no release impact.

The 5D audit summary called the setting "strict-off", a term used exactly
once in the document. Section 6 spells the same setting out as "require
branches up to date before merging" is off, and repeats it for develop as
"up to date" is off. Use the section 6 phrasing so the audit summary and
the ruleset description name the setting the same way.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
CopilotAI review requested due to automatic review settings July 18, 2026 18:00
@codecov

codecovBot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.89%. Comparing base (f391645) to head (c8c883b).

Additional details and impacted files
@@ Coverage Diff @@## develop #425 +/- ##
========================================
Coverage 66.89% 66.89% ========================================
Files 13 13 Lines 1160 1160 Branches 108 108 ========================================
Hits 776 776 Misses 338 338 Partials 46 46 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates WORKFLOW.md documentation to replace the shorthand strict-off label in the 5D audit summary with the explicit branch-ruleset setting wording used elsewhere in the doc, keeping terminology consistent within the workflow/audit guide.

Changes:

  • Replaces strict-off in the 5D configuration-audit summary with the spelled-out "require branches up to date before merging" ... off phrasing.

Comment threadWORKFLOW.md Outdated
The previous wording split the quoted setting name across a line break,
so searching for the exact label failed, and it read "... merging" off"
where section 6 reads "... merging" is off. Restructure the sentence so
the list ends before the clause, keeping the quoted name intact on a
single line.
Reflow the rest of the paragraph, which had drifted to a 142-character
line and two short ragged lines across the preceding edits. It now wraps
consistently near the file's ~105-character width.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
CopilotAI review requested due to automatic review settings July 18, 2026 18:06

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

WORKFLOW.md:592

  • This sentence is still missing is before **off**, so it doesn’t exactly match the section 6 phrasing (e.g., line 645: "..." is off) and reads a bit ungrammatically.
the `main`/`develop` rulesets enforce the required merge method + status check + signed commits, with
"require branches up to date before merging" **off**, and the repository settings (auto-merge, allowed
merge methods) are in place, reporting any drift. A missing or incorrect configuration item is a defect

@ptr727
ptr727 merged commit b890e31 into developJul 18, 2026
12 checks passed
@ptr727
ptr727 deleted the docs/strict-off-terminology branch July 18, 2026 18:08
@ptr727ptr727 mentioned this pull request Jul 18, 2026
ptr727 added a commit that referenced this pull request Jul 18, 2026
Promotion of #425 to `main`.
## Contents
| PR | Change |
| --- | --- |
| #425 | Spell out the up-to-date ruleset setting in the 5D audit
summary |
Replaces the one-off `strict-off` term with section 6's phrasing
(`"require branches up to date before merging"` **off**), so the audit
summary and the ruleset description name the setting identically. Review
also caught that the first attempt split the quoted label across a line
break, making it unsearchable -- fixed, and the paragraph reflowed to
the file's ~105-character width after earlier edits had left a
142-character line.
This closes out the terminology finding Copilot raised on #423, which
was deferred there as out of scope for that promotion.
## Release impact: no auto-publish
Docs-only. No shipped input touched, so no stable release fires. NuGet
stays at 4.0.18.
ptr727-codegenBot pushed a commit to ptr727/LanguageTags that referenced this pull request Jul 21, 2026
Updated [ptr727.Utilities](https://github.com/ptr727/Utilities) from
4.0.18 to 4.0.28.
<details>
<summary>Release notes</summary>
_Sourced from [ptr727.Utilities's
releases](https://github.com/ptr727/Utilities/releases)._
## 4.0.28
## What's Changed
* Bump the nuget-deps group with 3 updates by @​dependabot[bot] in
ptr727/Utilities#411
* Document the README + HISTORY cspell CI scope in CODESTYLE by @​ptr727
in ptr727/Utilities#413
* Document the README + HISTORY cspell CI scope (main-only) by @​ptr727
in ptr727/Utilities#414
* Bump actions/setup-dotnet from 5.4.0 to 6.0.0 in the actions-deps
group by @​dependabot[bot] in
ptr727/Utilities#415
* Bump actions/setup-dotnet from 5.4.0 to 6.0.0 in the actions-deps
group by @​dependabot[bot] in
ptr727/Utilities#416
* Refresh repo-config carry to current reference; add self-audit carry
by @​ptr727 in ptr727/Utilities#417
* Remove repo-wide analyzer relaxation and honor test cancellation by
@​ptr727 in ptr727/Utilities#418
* Add Codecov coverage shield to the README build status by @​ptr727 in
ptr727/Utilities#419
* Promote develop to main by @​ptr727 in
ptr727/Utilities#420
* Correct WORKFLOW.md audit flow and NUGET_USERNAME secret store by
@​ptr727 in ptr727/Utilities#422
* Describe the 5D audit as reporting defects, not failing by @​ptr727 in
ptr727/Utilities#424
* Promote develop to main by @​ptr727 in
ptr727/Utilities#423
* Spell out the up-to-date ruleset setting in the 5D audit summary by
@​ptr727 in ptr727/Utilities#425
* Promote develop to main by @​ptr727 in
ptr727/Utilities#426
* Bump DavidAnson/markdownlint-cli2-action from 24.0.0 to 24.1.0 in the
actions-deps group by @​dependabot[bot] in
ptr727/Utilities#429
* Bump the nuget-deps group with 1 update by @​dependabot[bot] in
ptr727/Utilities#431
**Full Changelog**:
ptr727/Utilities@4.0.18...4.0.28
Commits viewable in [compare
view](ptr727/Utilities@4.0.18...4.0.28).
</details>
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ptr727.Utilities&package-manager=nuget&previous-version=4.0.18&new-version=4.0.28)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727