Cache combined puli.json files of all installed packages

[msojda]

Fixespuli/issues#148.

[tgalopin]

I think you can add a small description about the class (and a author tag for you if you want :) ). In other classes as well.

[webmozart]

This is a good start already! :) Let's extract an interface PackageProvider out of PackageManager that contains all the methods related to fetching or querying packages. We can let CacheManager extend PackageProvider.

[webmozart]

Hi @msojda :) I refactored the JSON conversion a bit which should make it easier for you to implement this. Basically, you can implement JsonConverter in your own custom CacheFileConverter class and accept the JsonConverter for converting individual package files in the constructor (where we are going to inject the PackageFileConverter in Puli). This way, this should be fairly easy to solve.

[webmozart]

targetVersion is not supported here, since this is not a MigratingConverter. You can simply store it in the latest version.

[webmozart]

This looks good already :) With some more work we should be able to finish this.

[msojda]

Ping @tgalopin@webmozart :)

PS. If this is good and we can progress with it I remember there was other issue we were talking about and it was related to this one.

[webmozart]

Hey @msojda! What's the current status and what is needed to finish this? This PR looks good and I'd like to merge it soon.

[msojda]

Hi @webmozart. Just updated it with the latest repository changes. Ready to go for me! 😄

[webmozart]

Apparently you changed all the doc blocks to remove the dots. On purpose?

While we can do this, I wouldn't do it in this PR.

[msojda]

Yeah, I just did that cause StyleCI was failing 😞

[webmozart]

That was fast! :) Thanks for the quick update. Apart from my remarks, the cached modules should actually be used in the Container class. I think they should be used wherever we now call ->getModuleManager->get*(). That means, one needs to explicitly query the module manager in order to work with the fresh modules, which should be fine.

[msojda]

I'll update the PR tonight. Shall I update the Container class as well or that's the thing for another PR?

PS. Will you be available on Gitter? We could prioritise next tasks then 😄