You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Unfortunately, both runs still failed when a later Docker-context SSH connection was opened.
Run 1:
Fresh Lightsail instance created at 21:04:28
SSH readiness succeeded at 21:06:25
Docker context created at 21:06:49
At 21:12:45, Compose opened another connection and received: Permission denied (publickey,gssapi-keyex,gssapi-with-mic)
Time from Instance created to authentication failure: about 8m 16s
Run 2:
Fresh Lightsail instance created at 20:59:07
SSH readiness succeeded at 21:01:34
Docker context created at 21:02:04
At 21:07:24, Compose opened another connection and received: Permission denied (publickey,gssapi-keyex,gssapi-with-mic)
Time from Instance created to authentication failure: about 8m 17s
In both runs:
GitHub confirmed it downloaded and ran commit 1ebf6c7
deployment progressed normally for several minutes before authentication began failing
Established run-scoped SSH access for deployment never appeared
the final failure was Docker-over-SSH exit status 255
Given that handoffExpiringSSHAccess() is called after SSH readiness and returns early when Access.ExpiresAt.IsZero(), the missing handoff message appears to indicate that the Lightsail ExpiresAt value is arriving as a zero time. The action consequently continues using the temporary AWS certificate,
which then expires during Compose.
It may be worth logging the received ExpiresAt value and triggering the run-scoped key handoff whenever a Lightsail CertKey is present, even if ExpiresAt is missing or zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
make testmise exec -- go test ./...mise exec -- go test -race ./internal/pullpreview ./internal/providers/lightsailmise exec -- go vet ./...upx -t dist/pullpreview-linux-amd64Closes#138