Skip to content

Update pulp-nn-mixed submodule - #145

Merged
Xeratec merged 2 commits into
pulp-platform:develfrom
marchioa:fix-zero-mem
Jan 6, 2026
Merged

Update pulp-nn-mixed submodule#145
Xeratec merged 2 commits into
pulp-platform:develfrom
marchioa:fix-zero-mem

Conversation

@marchioa

@marchioamarchioa commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

This PR updates the pulp-nn-mixed submodule to include the fix for an illegal hardware loop configuration related to the pulp_zero_mem utility function PR10. The updated submodule removes the MemoryFence() from the loop, allowing the compiler to correctly generate a valid HW loop and preventing illegal configurations.

Added

  • nothing

Changed

  • pulp-nn-mixed submodule

Fixed

  • nothing

PR Merge Checklist

  1. The PR is rebased on the latest devel commit and pointing to devel.
  2. Your PR reviewed and approved.
  3. All checks are passing.
  4. The CHANGELOG.md file has been updated.
  5. If the docker was modified, change back its link after review.

@coderabbitai

coderabbitaiBot commented Dec 19, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Updated the submodule pointer for TargetLibraries/PULPOpen/third_party/pulp-nn-mixed to a newer commit and added a changelog entry. No code, API, runtime, or control flow changes.

Changes

Cohort / File(s)Summary
Submodule Update
TargetLibraries/PULPOpen/third_party/pulp-nn-mixed
Updated commit reference from b69ec23ec81595ebbec694f4a28d84022858af83 to a9b4aaf597c030ce24bf65a00b5f3ec84a1528c4.
Changelog
CHANGELOG.md
Added Unreleased entry: "Update submodule pulp-nn-mixed [#145]".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check nameStatusExplanation
Title check✅ PassedThe title 'Update pulp-nn-mixed submodule' accurately describes the main change—updating a submodule—and aligns with the changeset which only modifies the pulp-nn-mixed submodule pointer.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check✅ PassedThe pull request description clearly explains the purpose of the change: updating the pulp-nn-mixed submodule to fix an illegal hardware loop configuration issue related to the pulp_zero_mem utility function.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@XeratecXeratec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please update the changelog. We do this for every PR we merge.

@XeratecXeratec added the Feature Addition of new features label Dec 24, 2025
@XeratecXeratec added this to the Release 0.2.1 milestone Dec 24, 2025
@XeratecXeratec moved this to In review in DeeployDec 24, 2025
@Xeratec

Copy link
Copy Markdown
Member

Thanks for implementing the requested changes. I will approve and merge the PR once all the tests pass.

@XeratecXeratec moved this from In review to Ready for Merge in DeeployJan 5, 2026
@Xeratec
Xeratec merged commit 0b554e9 into pulp-platform:develJan 6, 2026
142 checks passed
@github-project-automationgithub-project-automationBot moved this from Ready for Merge to Done in DeeployJan 6, 2026
@marchioa
marchioa deleted the fix-zero-mem branch January 6, 2026 10:15
@coderabbitaicoderabbitaiBot mentioned this pull request Feb 3, 2026
5 tasks
This was referenced Feb 5, 2026
Victor-Jung added a commit that referenced this pull request Feb 5, 2026
This release includes improvements to the tiling and DMA code
generation, new networks and operators, improved CI workflows, migration
to PyTest, and support for PyPi package releases.
Note: Since the release tag references the Docker container tagged with
the release tag (ghcr.io/pulp-platform/deeploy:v0.2.1), the CI will
initially fail. The Deeploy Docker image must be built after the release
PR is merged and the CI restarted.
### List of Pull Requests
- PyPi Package Deployment + Remove Banshee Dept
[#154](#154)
- PyTest Migration
[#144](#144)
- Update submodule `pulp-nn-mixed`
[#145](#145)
- Improve Profiling
[#138](#138)
- FP32 ReduceMean operator improvement
[#137](#137)
- Support for RMSNorm (Pow and Sqrt operators)
[#136](#136)
- Demo TinyViT compatibility with tiled Siracusa
[#124](#124)
- TinyViT on non-tiled Siracusa
[#117](#117)
- Support Fully Asynchronous DMAs
[#114](#114)
- Disallow shape inference
[#128](#128)
- Remove memory-aware node bindings
[#123](#123)
- Fix missing const's layout transformation and refactor NCHWtoNHWC
passes [#122](#122)
- Fix aliasing [#125](#125)
- Support for 1D Autoencoder
[#98](#98)
- Refactor Logging for Improved Debugging
[#115](#115)
- Add reuse-tool as an SPDX license header linter
[#113](#113)
- Bug fixes, API Cleanup and Reduce Compiler Warning on PULP
[#112](#112)
- Fix PULP GEMM `batch` serialization
[#109](#109)
- Split CI Workflows by Platform and Task, Improve Formatting and
Linting Reliability
[#108](#108)
- Refactor tiling code generation
[#105](#105)
- Change order of typeMatching entries
[#68](#68)
- Node Mangling to avoid duplication
[#93](#93)
- Prepare Post v0.2.0 Release
[#104](#104)
- Use Docker digests instead of arch-specific tags
[#106](#106)
- Fix `Unsqueeze` Op. when using ONNX opset 13 or higher (from attribute
to input) [#119](#119)
- Fix bias hoisting in generic GEMM with no bias
[#126](#126)
@coderabbitaicoderabbitaiBot mentioned this pull request Apr 30, 2026
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FeatureAddition of new features

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants

@marchioa@Xeratec