Do not fetch QEMU's ROM submodules

[gamzeisl]

Fixes the toolchain build, which currently fails due to QEMU submodules.

The QEMU checkout ran git submodule update --init --recursive, which descends into roms/edk2 and from there into edk2's own submodules. One of those pins cmocka to https://git.cryptomilk.org/projects/cmocka.git, which no longer serves a git repository, so the clone aborts.

The ROM submodules are not needed. QEMU's configure initialises what the build requires — ui/keycodemapdb, meson, dtc, capstone, slirp and the berkeley float libraries — through scripts/git-submodule.sh, and roms/edk2 is not among them. Dropping the line also saves fetching ~20 firmware submodules on every image build.

Fixed

• Do not fetch QEMU's ROM submodules when building the toolchain.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6724565a-ade4-4b66-a471-1b47bb5e90e0

📥 Commits

Reviewing files that changed from the base of the PR and between bf64cfa and 77ad65e.

📒 Files selected for processing (1)

• Makefile

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Summary by CodeRabbit

• Chores
  • Updated the QEMU source checkout process to avoid initializing recursive submodules when cloning the stable-6.1 branch.

Walkthrough

The Makefile now performs only a shallow clone of QEMU’s stable-6.1 branch. It no longer enters the checkout directory or initializes recursive submodules.

Changes

QEMU checkout

Layer / File(s)	Summary
Simplify clone command Makefile	The QEMU clone command retains the shallow stable-6.1 clone and removes directory entry and recursive submodule initialization.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk:⚪ Minimal · up to 77ad6

This localized build change avoids fetching unnecessary QEMU ROM submodules and addresses the reported toolchain build failure; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers:runwangdl

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly states the main change: avoiding QEMU ROM submodule fetching.
Description check	✅ Passed	The description directly explains the build failure, the unnecessary ROM submodules, and the intended fix.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gamzeisl]

Verified as part of another branch, which contains this commit: the container image builds successfully (run).

[Victor-Jung]

Good change, thanks for fixing this before I bump into the issue 😁