Skip to content

Reduce Mean Float Template - #92

Merged
Xeratec merged 11 commits into
pulp-platform:develfrom
diaconuccalin:reduce_mean_float_template
Jun 17, 2025
Merged

Reduce Mean Float Template#92
Xeratec merged 11 commits into
pulp-platform:develfrom
diaconuccalin:reduce_mean_float_template

Conversation

@diaconuccalin

@diaconuccalindiaconuccalin commented Jun 4, 2025•
edited by Xeratec
Loading

Copy link
Copy Markdown
Contributor

Created the float generic reduce mean parser and template, since old one was designed for quantized networks and incompatible with fp data.

Added

  • Generic FP32 reduce mean bindings, parser, and template

Changed

Fixed

  • DW Conv2D kernel header to avoid warnings
  • float casting in GELU kernel to avoid warnings

PR Merge Checklist

  1. The PR is rebased on the latest devel commit and pointing to devel.
  2. Your PR reviewed and approved.
  3. All checks are passing.
  4. The CHANGELOG.md file has been updated.
  5. If the docker was modified, change back its link after review.

@diaconuccalindiaconuccalin self-assigned this Jun 4, 2025
@diaconuccalindiaconuccalin added the Feature Addition of new features label Jun 4, 2025
@XeratecXeratec added this to the Release xxx milestone Jun 5, 2025
@XeratecXeratec moved this to Need Reviewer in DeeployJun 5, 2025
Xeratec
Xeratec reviewed Jun 5, 2025
View reviewed changes

@XeratecXeratec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!. I especially like fixing the types to explicitly select the bit width. I think this should be done everywhere and is good practice in general.

I have one suggestion, one comment and one questions.

Comment threadTargetLibraries/Generic/src/GELU_fp32.c Outdated
Comment threadDeeploy/Targets/Generic/Bindings.py Outdated
Comment threadDeeploy/Targets/Generic/Parsers.py Outdated
@XeratecXeratec moved this from Need Reviewer to In review in DeeployJun 5, 2025
@XeratecXeratec modified the milestones: Release xxx, Release 0.2.0Jun 5, 2025
@diaconuccalin
Merge branch 'devel' into reduce_mean_float_template
d686d76
Signed-off-by: Călin Diaconu <diaconuccalin@gmail.com>
@diaconuccalin
Adjusted slice float bindings and GELU float casting
11d4049
@diaconuccalin
Merge branch 'devel' into reduce_mean_float_template
693c6fa
Signed-off-by: Călin Diaconu <diaconuccalin@gmail.com>
@diaconuccalin
Merged ReduceMean float parserand mapper into old one. Added small, d…
bebfed3
…emo generic float TinyViT test files and into CI pipeline
Xeratec
Xeratec approved these changes Jun 17, 2025
View reviewed changes

@XeratecXeratec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I only have one very small comment to avoid some duplication. I am aware that this is a personal preference. If you do not agree, just resolve and we merge it.

Comment threadDeeploy/Targets/Generic/Bindings.py Outdated
@XeratecXeratec mentioned this pull request Jun 17, 2025
Open
diaconuccalinand others added 2 commits June 17, 2025 20:31
@diaconuccalin@Xeratec
Unify slice float and int bindings
b5d9529
Co-authored-by: Philip Wiese <wiesep@iis.ee.ethz.ch>
Signed-off-by: Călin Diaconu <diaconuccalin@gmail.com>
@diaconuccalin
Quickfix in bindings
dff62b2
Signed-off-by: Călin Diaconu <diaconuccalin@gmail.com>
@Xeratec
Xeratec merged commit 690cb2c into pulp-platform:develJun 17, 2025
@github-project-automationgithub-project-automationBot moved this from In review to Done in DeeployJun 17, 2025
@XeratecXeratec mentioned this pull request Jul 8, 2025
Merged
Xeratec added a commit that referenced this pull request Jul 8, 2025
@Xeratec
Release v0.2.0 (#103)
c7fd2a1
This release contains major architectural changes, new platform support,
enhanced simulation workflows, floating-point kernel support, training
infrastructure for CCT models, memory allocation strategies, and
documentation improvements.
After merging this into `main`, the release process will proceed with:
- Pushing a Git tag for the release after merging this PR
- Creating a GitHub release with the prepared tag.
Note: Since the release tag references the Docker container tagged with
the release tag (`ghcr.io/pulp-platform/deeploy:v0.2.0`), the CI will
initially fail. The Deeploy Docker image must be built after the release
PR is merged and the CI restarted.
### List of Pull Requests
- Prepare v0.2.0 release
[#102](#102)
- Add Luka as Code Owner
[#101](#101)
- Fix CI, Docker Files, and Documentation Workflow
[#100](#100)
- Chimera Platform Integration
[#96](#96)
- Add Tutorial and Refactor README
[#97](#97)
- Reduce Mean Float Template
[#92](#92)
- Reshape Memory Freeing and Generic Float GEMM Fixes
[#91](#91)
- Prepare for Release and Separate Dependencies
[#90](#90)
- Fix input offsets calculation
[#89](#89)
- Move PULP SDK to main branch/fork
[#88](#88)
- Finite Lifetime for IO Tensors
[#51](#51)
- Improved Memory Visualization and Multi-Layer Tiling Profiling
[#56](#56)
- Fix Linting in CI and Reformat C Files
[#86](#86)
- Fix Broken CMake Flow For pulp-sdk
[#87](#87)
- Refactor Changelog For Release
[#85](#85)
- ARM Docker Container and Minor Bug Fix
[#84](#84)
- Added Kernel for Generic Float DW Conv2D
[#63](#63)
- Autoselect Self-Hosted Runners if the Action is on Upstream
[#81](#81)
- TEST_RECENT linking on MacOS
[#78](#78)
- Add RV32IMF Picolibc support for Siracusa platform
[#66](#66)
- Improve Documentation and VSCode Support
[#76](#76)
- Debug Print Topology Pass and Code Transformation
[#75](#75)
- Find all subdirectories of Deeploy when installing with pip install
[#70](#70)
- Add milestone issue template
[#71](#71)
- Bunch of fixes and changes
[#58](#58)
- Add SoftHier platform
[#65](#65)
- rv32imf_xpulpv2 ISA support for Siracusa platform
[#64](#64)
- One LLVM To Compile Them All
[#60](#60)
- One GVSoC to Simulate Them All
[#59](#59)
- Add Support for CCT Last Layer Training with Embedding Dim 8-128
[#55](#55)
- Add CCT Classifier Training Support
[#53](#53)
- L3 Bugs: DMA Struct Datatype and Maxpool Margin Error
[#45](#45)
- DeepQuant Quantized Linear Support
[#54](#54)
- Implemented Dequant Layer for Generic and Siracusa
[#52](#52)
- Infinite Lifetime Buffers Considered in Tiling & Memory Allocation (+
Visualization) [#44](#44)
- Implemented Quant Layer for Generic and Siracusa
[#49](#49)
- Increase maximal Mchan DMA transfer sizes from 64KiB to 128KiB
[#47](#47)
- Add MiniMalloc and Decouple Memory Allocation and Tiling
[#40](#40)
- Float CCT Bugs on L3
[#37](#37)
- Memory Allocation Strategies and Visualization
[#36](#36)
- Add CODEOWNERS [#42](#42)
- Add Tiling Support to All CCT Kernels and Fix CCT Operators on
Siracusa Platform for L2
[#35](#35)
- Add Fp gemm and Softmax for Snitch platform
[#31](#31)
- Add Float Kernels for CCT
[#29](#29)
- documentation deployment
[#34](#34)
- main.c Float Cast Bugs
[#28](#28)
- Add Float GEMM on PULP with Tiling
[#26](#26)
- Add Float Support & Float GEMM for Generic
[#25](#25)
- GVSOC support for the Snitch Cluster platform
[#23](#23)
- Snitch Cluster Tiling Support
[#22](#22)
- Snitch support integration
[#14](#14)
- Update bibtex citation
[#20](#20)
- the PR template location, bump min python to 3.10, change install
command [#17](#17)
- Add pre-commit for python formatting
[#15](#15)
- FP integration (v2)
[#12](#12)
- shell for sequential tests of Generic, Cortex, and Mempool platforms
[#11](#11)
- Add issue templates
[#10](#10)
- Minor CI and Readme Improvements
[#8](#8)
- Fix GHCR Link for Docker Build
[#7](#7)
- neureka's ccache id
[#6](#6)
- GitHub-based CI/CD Flow
[#4](#4)
- Generic Softmax Kernel
[#2](#2)
- Port GitLab CI [#1](#1)
@diaconuccalin
diaconuccalin deleted the reduce_mean_float_template branch November 19, 2025 10:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XeratecXeratecXeratec approved these changes
@Victor-JungVictor-JungAwaiting requested review from Victor-JungVictor-Jung is a code owner
+1 more reviewer
@lukamaclukamaclukamac left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@diaconuccalindiaconuccalin

Labels

FeatureAddition of new features

Projects

Deeploy
Status: Done

Milestone

Release 0.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@diaconuccalin@Xeratec@lukamac@Victor-Jung