Uh oh!
There was an error while loading. Please reload this page.
Derive the CI Python version from the package's requires-python. - #1050
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
| {{ checkout(depth=0, path=plugin_name) | indent(6) }} | ||
| {{ setup_python("3.12") | indent(6) }} | ||
| {{ setup_python() | indent(6) }} |
There was a problem hiding this comment.
I think this workflow does not execute any code from the plugin. So it should be fine (and maybe wise?) to let the template decide.
There was a problem hiding this comment.
Not a blocking requirement however...
We could also start transitioning this job to uv.
There was a problem hiding this comment.
It already uses uv: https://github.com/pulp/plugin_template/blob/main/templates/include/macros.j2#L40
All the ci jobs should use uv now.
There was a problem hiding this comment.
Sorry I was not wording this right. The templates use uv pip install as a drop in replacement (makes me wonder if you could even do alias pip "uv pip" these days.).
What I meant was using uv run --script instead, where the script tells uv it needs gitpython.
Anyway none of this ought to block this PR.
| {{ checkout(depth=0, path=plugin_name) | indent(6) }} | ||
| {{ setup_python("3.12") | indent(6) }} | ||
| {{ setup_python() | indent(6) }} |
There was a problem hiding this comment.
Sorry I was not wording this right. The templates use uv pip install as a drop in replacement (makes me wonder if you could even do alias pip "uv pip" these days.).
What I meant was using uv run --script instead, where the script tells uv it needs gitpython.
Anyway none of this ought to block this PR.
Uh oh!
There was an error while loading. Please reload this page.
This will allow us to upgrade to require>=3.12 without worry of older branches.
📜 Checklist
See: Pull Request Walkthrough