Add method for checking date visibility. Improve scrolling method to consider if header is pinned.

[randomstep]

I wanted to check if a date is already displayed, so I know whether to scroll to it, or for example to hide the calendar if it is already in view.

I also wanted the scrolling to actually show the date itself, not just the month. So I made both my new method and the scrolling method check for pinning, and go to the exact row or the section based on whether header pinning is turned on.

Suggestions for refactoring out the duplicate code for checking pinsHeaderToTop? It bugs me but so does adding something like pinnedIndexPathForRowAtDate:. Could also do indexPathForRowAtDate:IgnorePinning: where the second argument is a BOOL on whether to use pinning or not. Or maybe is whether to return the header row for the month instead of the exact row. That doesn't seem like a great solution either.

[puls]

Check your indentation.

[randomstep]

Fixed.

[puls]

Not sure how I feel about this particular change, as it represents a break from backwards compatibility. Are you using a calendar view that's not big enough to display the whole month at once?

[randomstep]

I am, yes. I think deferring to "pinsHeaderToTop" makes consistent and expected behavior. Otherwise "scrollToDate" is just "scrollToMonth". I can see how it wouldn't matter so much if you display the whole month.

[randomstep]

I wanted to check if a date is already displayed, so I know whether to scroll to it, or for example to hide the calendar if it is already in view.

I also wanted the scrolling to actually show the date itself, not just the month. So I made both my new method and the scrolling method check for pinning, and go to the exact row or the section based on whether header pinning is turned on.

Suggestions for refactoring out the duplicate code for checking pinsHeaderToTop? It bugs me but so does adding something like pinnedIndexPathForRowAtDate:. Could also do indexPathForRowAtDate:IgnorePinning: where the second argument is a BOOL on whether to use pinning or not. Or maybe is whether to return the header row for the month instead of the exact row. That doesn't seem like a great solution either.

[puls]

Check your indentation.

[randomstep]

Fixed.

[puls]

Not sure how I feel about this particular change, as it represents a break from backwards compatibility. Are you using a calendar view that's not big enough to display the whole month at once?

[randomstep]

I am, yes. I think deferring to "pinsHeaderToTop" makes consistent and expected behavior. Otherwise "scrollToDate" is just "scrollToMonth". I can see how it wouldn't matter so much if you display the whole month.

[randomstep]

I wanted to check if a date is already displayed, so I know whether to scroll to it, or for example to hide the calendar if it is already in view.

I also wanted the scrolling to actually show the date itself, not just the month. So I made both my new method and the scrolling method check for pinning, and go to the exact row or the section based on whether header pinning is turned on.

Suggestions for refactoring out the duplicate code for checking pinsHeaderToTop? It bugs me but so does adding something like pinnedIndexPathForRowAtDate:. Could also do indexPathForRowAtDate:IgnorePinning: where the second argument is a BOOL on whether to use pinning or not. Or maybe is whether to return the header row for the month instead of the exact row. That doesn't seem like a great solution either.

[puls]

Check your indentation.

[randomstep]

Fixed.

[puls]

Not sure how I feel about this particular change, as it represents a break from backwards compatibility. Are you using a calendar view that's not big enough to display the whole month at once?

[randomstep]

I am, yes. I think deferring to "pinsHeaderToTop" makes consistent and expected behavior. Otherwise "scrollToDate" is just "scrollToMonth". I can see how it wouldn't matter so much if you display the whole month.

[randomstep]

I wanted to check if a date is already displayed, so I know whether to scroll to it, or for example to hide the calendar if it is already in view.

I also wanted the scrolling to actually show the date itself, not just the month. So I made both my new method and the scrolling method check for pinning, and go to the exact row or the section based on whether header pinning is turned on.

Suggestions for refactoring out the duplicate code for checking pinsHeaderToTop? It bugs me but so does adding something like pinnedIndexPathForRowAtDate:. Could also do indexPathForRowAtDate:IgnorePinning: where the second argument is a BOOL on whether to use pinning or not. Or maybe is whether to return the header row for the month instead of the exact row. That doesn't seem like a great solution either.

[puls]

Check your indentation.

[randomstep]

Fixed.

[puls]

Not sure how I feel about this particular change, as it represents a break from backwards compatibility. Are you using a calendar view that's not big enough to display the whole month at once?

[randomstep]

I am, yes. I think deferring to "pinsHeaderToTop" makes consistent and expected behavior. Otherwise "scrollToDate" is just "scrollToMonth". I can see how it wouldn't matter so much if you display the whole month.

[randomstep]

I wanted to check if a date is already displayed, so I know whether to scroll to it, or for example to hide the calendar if it is already in view.

I also wanted the scrolling to actually show the date itself, not just the month. So I made both my new method and the scrolling method check for pinning, and go to the exact row or the section based on whether header pinning is turned on.

Suggestions for refactoring out the duplicate code for checking pinsHeaderToTop? It bugs me but so does adding something like pinnedIndexPathForRowAtDate:. Could also do indexPathForRowAtDate:IgnorePinning: where the second argument is a BOOL on whether to use pinning or not. Or maybe is whether to return the header row for the month instead of the exact row. That doesn't seem like a great solution either.

[puls]

Check your indentation.

[randomstep]

Fixed.

[puls]

Not sure how I feel about this particular change, as it represents a break from backwards compatibility. Are you using a calendar view that's not big enough to display the whole month at once?

[randomstep]

I am, yes. I think deferring to "pinsHeaderToTop" makes consistent and expected behavior. Otherwise "scrollToDate" is just "scrollToMonth". I can see how it wouldn't matter so much if you display the whole month.

[randomstep]

I wanted to check if a date is already displayed, so I know whether to scroll to it, or for example to hide the calendar if it is already in view.

I also wanted the scrolling to actually show the date itself, not just the month. So I made both my new method and the scrolling method check for pinning, and go to the exact row or the section based on whether header pinning is turned on.

Suggestions for refactoring out the duplicate code for checking pinsHeaderToTop? It bugs me but so does adding something like pinnedIndexPathForRowAtDate:. Could also do indexPathForRowAtDate:IgnorePinning: where the second argument is a BOOL on whether to use pinning or not. Or maybe is whether to return the header row for the month instead of the exact row. That doesn't seem like a great solution either.

[puls]

Check your indentation.

[randomstep]

Fixed.

[puls]

Not sure how I feel about this particular change, as it represents a break from backwards compatibility. Are you using a calendar view that's not big enough to display the whole month at once?

[randomstep]

I am, yes. I think deferring to "pinsHeaderToTop" makes consistent and expected behavior. Otherwise "scrollToDate" is just "scrollToMonth". I can see how it wouldn't matter so much if you display the whole month.

[randomstep]

I wanted to check if a date is already displayed, so I know whether to scroll to it, or for example to hide the calendar if it is already in view.

I also wanted the scrolling to actually show the date itself, not just the month. So I made both my new method and the scrolling method check for pinning, and go to the exact row or the section based on whether header pinning is turned on.

Suggestions for refactoring out the duplicate code for checking pinsHeaderToTop? It bugs me but so does adding something like pinnedIndexPathForRowAtDate:. Could also do indexPathForRowAtDate:IgnorePinning: where the second argument is a BOOL on whether to use pinning or not. Or maybe is whether to return the header row for the month instead of the exact row. That doesn't seem like a great solution either.

[puls]

Check your indentation.

[randomstep]

Fixed.

[puls]

Not sure how I feel about this particular change, as it represents a break from backwards compatibility. Are you using a calendar view that's not big enough to display the whole month at once?

[randomstep]

I am, yes. I think deferring to "pinsHeaderToTop" makes consistent and expected behavior. Otherwise "scrollToDate" is just "scrollToMonth". I can see how it wouldn't matter so much if you display the whole month.

[randomstep]

I wanted to check if a date is already displayed, so I know whether to scroll to it, or for example to hide the calendar if it is already in view.

I also wanted the scrolling to actually show the date itself, not just the month. So I made both my new method and the scrolling method check for pinning, and go to the exact row or the section based on whether header pinning is turned on.

Suggestions for refactoring out the duplicate code for checking pinsHeaderToTop? It bugs me but so does adding something like pinnedIndexPathForRowAtDate:. Could also do indexPathForRowAtDate:IgnorePinning: where the second argument is a BOOL on whether to use pinning or not. Or maybe is whether to return the header row for the month instead of the exact row. That doesn't seem like a great solution either.

[puls]

Check your indentation.

[randomstep]

Fixed.

[puls]

Not sure how I feel about this particular change, as it represents a break from backwards compatibility. Are you using a calendar view that's not big enough to display the whole month at once?

[randomstep]

I am, yes. I think deferring to "pinsHeaderToTop" makes consistent and expected behavior. Otherwise "scrollToDate" is just "scrollToMonth". I can see how it wouldn't matter so much if you display the whole month.