Uh oh!
There was an error while loading. Please reload this page.
Topic/remove plus - #20
Merged
srghma-old merged 2 commits intoApr 9, 2021
Merged
Conversation
Fix up tests, we can't use guard anymore, but that's ok, as it doesn't give an error message anyway.
HuwCampbell
commented
Apr 13, 2021
ContributorAuthor
Cool. After purescript/purescript-maybe#45 it looks like the little version I forked inline can probably be removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nice port.
Purescript's class hierarchy is more granular than Haskell's; and has in its prelude an
AltprecedingAlternative.In the Haskell version, a parser is essentially a free
Alternative, withNilP Nonebeing empty, andNilP . Justbeing pure. But we don't actually need the empty at all though; and really its existence just means there are places where we can't give meaningful error messages.Similarly, the empty on
ReadMjust gives no error message, which is pretty awful.I'm not sure how much you plan on deviating from our version; nor whether you are up for breaking changes. I mostly did this to know I may be able to in the future in the Haskell version.
So feel free to not merge this (and I would probably suggest against it until purescript/purescript-maybe#45 is addressed).