Uh oh!
There was an error while loading. Please reload this page.
chore: finalize traverse fix — mapWithIndex, regression test, tooling alignment - #4
Merged
Merged
Conversation
Follows the merged traverse fix (#2 by @Renegatto). On top of it: - Fix mapWithIndexArray: it passed the 1-based Lua loop index to f, but PureScript mapWithIndex is 0-based, so f received i instead of i-1 (originally reported in #1 by @sarahnya). - Add a focused regression suite (test-regression/) run by scripts/test: traverse over Maybe is length/order-preserving at every size (>3 hits the pivot/append branch, which needs the Array Semigroup fix shipped in prelude v7.2.2), traverse over the Array applicative, and 0-based mapWithIndex. - Align tooling: purescript-overlay dev shell on Lua 5.1 (drops easy-ps / insecure nodejs), canonical nix CI replacing the bower workflow, fail-fast scripts, and bump the package set to psc-0.15.15-20260614 (prelude v7.2.2). Supersedes the earlier normalization PR #3. Closes#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on the merged traverse fix (#2 by @Renegatto) to fully close out the Array
traverse/mapWithIndexbugs and bring the fork to the canonical tooling.mapWithIndex (0-based).
mapWithIndexArraypassed the 1-based Lua loop index tof, but PureScriptmapWithIndexis 0-based — sofsawiinstead ofi - 1. Fixed (originally reported in #1 by @sarahnya).Regression suite.
test-regression/(run byscripts/test) covers:traverseoverMaybeis length- and order-preserving at sizes 0–8 (sizes > 3 exercise the divide-and-conquer pivot branch — the one that appends sub-results, which only works with the Array Semigroup fix shipped inpreludev7.2.2),traverseover the Array applicative, and 0-basedmapWithIndex. Verified green on Lua 5.1.Tooling alignment. purescript-overlay dev shell pinned to Lua 5.1 (drops easy-purescript-nix and its EOL/insecure nodejs, so plain
nix developevaluates), canonical nix CI replacing the inherited bower workflow, fail-fastscripts/build/scripts/test, and the package set bumped topsc-0.15.15-20260614(which carriespreludev7.2.2). Supersedes the earlier tooling-normalization PR #3.Closes#1.