Skip to content

chore: align CI to the hardened canon, add AGENTS.md - #3

Merged
Unisay merged 1 commit into
masterfrom
chore/agents-md-and-canon-ci
Jun 14, 2026
Merged

chore: align CI to the hardened canon, add AGENTS.md#3
Unisay merged 1 commit into
masterfrom
chore/agents-md-and-canon-ci

Conversation

@Unisay

Copy link
Copy Markdown
Collaborator

Brings this fork in line with the shared tooling canon and gives the AI coding agents a single source of truth.

CI (.github/workflows/ci.yml):

  • Drop accept-flake-config = true. It let a PR's own flake nixConfig inject extra substituters and keys, which is a supply-chain risk; the caches are already pinned in extra_nix_config, so nothing is lost.
  • luacheck now runs --std lua51 --no-unused-args instead of --std min. lua51 matches the actual target (it knows math.pow/math.atan2, which min flags), and --no-unused-args tolerates the curried fallback args the native FFI stubs ignore.
  • Run the test step as bash ./scripts/test so it no longer depends on the file's execute bit.

AGENTS.md + CLAUDE.md:

  • AGENTS.md is the one instruction file the coding agents read natively (Codex, Cursor, Copilot, Gemini CLI, Aider): the build/test/lint commands, the Lua 5.1 constraints, the FFI parenthesisation rule, and the toolchain pins.
  • CLAUDE.md is a one-line @AGENTS.md import so Claude Code reads the same file instead of a second copy that drifts out of sync.

It also drops the dead .eslintrc.json, bower.json, package.json left over from the JavaScript build; the toolchain is spago plus nix now.

Tooling and docs only, no src/ change, so there is no tag or package-set bump.

Verification

nix develop -c ./scripts/build, the regression suite (bash ./scripts/test), and luacheck with --std lua51 --no-unused-args src/ are clean locally.

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns this fork’s CI and contributor/agent instructions with the shared hardened tooling canon for the PureScript→Lua (Lua 5.1) workflow, and removes legacy JavaScript build artifacts that are no longer used.

Changes:

  • Harden Nix CI by dropping accept-flake-config, adjust the test invocation to not depend on execute bits, and tune luacheck to Lua 5.1 with --no-unused-args.
  • Add AGENTS.md as the single source of truth for agent/dev commands and constraints, and make CLAUDE.md import it.
  • Remove obsolete JS-era tooling files (package.json, bower.json, .eslintrc.json).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
FileDescription
.github/workflows/ci.ymlHardens Nix config handling; adjusts test invocation and luacheck flags for Lua 5.1.
AGENTS.mdAdds canonical agent instructions (commands, Lua 5.1 constraints, FFI export rule, toolchain pins).
CLAUDE.mdImports AGENTS.md to keep Claude instructions in sync.
package.jsonRemoves legacy Node/Pulp-based scripts and dev dependencies.
bower.jsonRemoves legacy Bower dependency manifest.
.eslintrc.jsonRemoves legacy ESLint configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread.github/workflows/ci.yml
@Unisay
Unisayforce-pushed the chore/agents-md-and-canon-ci branch 3 times, most recently from cf37b94 to de13195CompareJune 14, 2026 17:11
@Unisay
Unisay marked this pull request as ready for review June 14, 2026 17:12
CI: drop accept-flake-config (supply-chain risk; caches already pinned),
run luacheck with --std lua51 --no-unused-args (matches the Lua 5.1 target
and the curried-FFI idiom), invoke the test step via bash so it no longer
needs the execute bit.
AGENTS.md is the single instruction file the coding agents read natively;
CLAUDE.md is a one-line @AGENTS.md import so Claude Code shares it. Also
removes dead JavaScript-era package files. Tooling and docs only, no src/.
@Unisay
Unisayforce-pushed the chore/agents-md-and-canon-ci branch from de13195 to bebcf0aCompareJune 14, 2026 17:18
@Unisay
Unisay merged commit e55cf13 into masterJun 14, 2026
1 check passed
@Unisay
Unisay deleted the chore/agents-md-and-canon-ci branch June 14, 2026 17:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Unisay