Uh oh!
There was an error while loading. Please reload this page.
Update to PureScript v0.15.0 - #34
Merged
thomashoneyman merged 17 commits intoMar 22, 2022
Merged
Conversation
The changes are interesting WRT require, as it should still be in existance in ESM but is CJS specific https://nodejs.org/api/esm.html#require __filename and __dirname are probably broken
Some of these bindings are no longer available with es modules, and all of them are dodgy (and probably in the wrong place).
sigma-andex
commented
Mar 22, 2022
ContributorAuthor
Uh oh!
There was an error while loading. Please reload this page.
thomashoneyman
approved these changes
Mar 22, 2022
JordanMartinez
approved these changes
Mar 22, 2022
JordanMartinez
commented
Mar 22, 2022
Contributor
@sigma-andex Looks like the |
sigma-andex
commented
Mar 22, 2022
ContributorAuthor
Sorry I oversaw that one. I updated the eslintrc but I forgot how to update your script. All four matches failed |
Uh oh!
There was an error while loading. Please reload this page.
JordanMartinez
commented
Mar 22, 2022
Contributor
No worries! I didn't exactly document that part initially and then changed how it worked a few days ago. |
JordanMartinez
approved these changes
Mar 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Backlinking to purescript/purescript#4244
Migrates FFI to ES modules
Checklist: