Skip to content

Update for v0.14.0-rc2 - #16

Merged
JordanMartinez merged 7 commits into
purescript:masterfrom
JordanMartinez:upFor14
Oct 8, 2020
Merged

Update for v0.14.0-rc2#16
JordanMartinez merged 7 commits into
purescript:masterfrom
JordanMartinez:upFor14

Conversation

@JordanMartinez

@JordanMartinezJordanMartinez commented Oct 4, 2020

Copy link
Copy Markdown
Contributor

No description provided.

JordanMartinez
JordanMartinez commented Oct 4, 2020
View reviewed changes
Comment threadsrc/Partial/Unsafe.purs
garyb
garyb requested changes Oct 4, 2020
View reviewed changes
Comment threadsrc/Partial.js Outdated
Comment threadsrc/Partial/Unsafe.purs
Comment threadsrc/Partial/Unsafe.purs Outdated
@JordanMartinez

JordanMartinez commented Oct 4, 2020

Copy link
Copy Markdown
ContributorAuthor

I've addressed your concerns. Let me know whether there's anything else we need done.

@JordanMartinez

JordanMartinez commented Oct 8, 2020

Copy link
Copy Markdown
ContributorAuthor

CI now builds. I didn't update the test code and that's what caused the failure.

garyb
garyb approved these changes Oct 8, 2020
View reviewed changes

@garybgaryb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JordanMartinez
JordanMartinez merged commit 7fb7e29 into purescript:masterOct 8, 2020
@JordanMartinez
JordanMartinez deleted the upFor14 branch October 8, 2020 14:15
@JordanMartinezJordanMartinez mentioned this pull request Oct 8, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garybgarybgaryb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JordanMartinez@garyb