Uh oh!
There was an error while loading. Please reload this page.
Add startsWith and endsWith - #147
Conversation
This is because like `stripPrefix` and `stripSuffix`, these functions are CodeUnit/CodePoint-agnostic. The same was also done for tests.
Please, don't fix older commits in newer ones A problem introduced by commit X should be fixed in commit X, otherwise reviewing the code becomes very hard, as well as reading the git history after this gets merged. See also this post from Linux HID subsystem and libinput maintainer Peter Hutterer. Despite the post age it's well relevant today, "old but gold". |
triallax
commented
Feb 21, 2025
@Hi-Angel thanks for the advice, but i'm not interested in purescript anymore (i haven't used it in years), feel free to take this up if you'd like |
f-f
left a comment
There was a problem hiding this comment.
I went through the discussion again and it looks like we have consensus for a merge (I just stumbled on this again as I was looking why we don't have this in core) - merging
Uh oh!
There was an error while loading. Please reload this page.

Description of the change
Add
startsWithandendsWithfunctions toData.String.CodeUnits.Fixes#127.
I know that there's still a bit of disagreement over whether this should be done or not, but I just opened this PR because it didn't take a lot of time. If it's ultimately decided against, feel free to close this PR.
To do:
stripPrefixandstripSuffixstripPrefixandstripSuffixData.String.NonEmptyChecklist: