Uh oh!
There was an error while loading. Please reload this page.
allow for title and unwatched filters - #370
Conversation
pkkid
commented
Jul 31, 2019
It's small, but this is an API breaking change and needs the major version incremented before pushing to pypi. |
blacktwin
commented
Jul 31, 2019
Sorry for being naive, but why, how? And what can I do to assist? |
Not naive, just that a variable name change in a function definition will break existing code. If someone is calling that function and specifying |
blacktwin
commented
Sep 20, 2019
@Hellowlol With the exception of aforementioned major version update, is there anything else I can do for this PR? |
Hellowlol
commented
Apr 27, 2020
This dont seems to be a breaking change? He didnt change a keyword argument. Why was the title changed btw? |
blacktwin
commented
Jul 27, 2020
The change would allow for the use of kwarg # Currentlyplex.createPlaylist(title="Naming of Playlist", title="Title Filter") # will not workplex.createPlaylist(title="Naming of Playlist", **{"title":"Title Filter"}) # will work# PRplex.createPlaylist(playlistTitle="Naming of Playlist", title="Title Filter")
plex.createPlaylist(playlistTitle="Naming of Playlist", **{"title":"Title Filter"}) |
Hellowlol
commented
Jul 27, 2020
Ah, i forgot about smart playlists. In the mean time lets just push this back to the next version. Its possible to handle this correctly by using _createSmart |
JonnyWong16
commented
Jun 7, 2021
Changed in #763. |
Addressing issue #221