Uh oh!
There was an error while loading. Please reload this page.
Add ability to customize XML includes when reloading object - #607
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Hellowlol
commented
Nov 21, 2020
Looks good! We only need tests to verify that the behavior is as expected and that we don’t break anything. |
Hellowlol
commented
Nov 21, 2020
Nice. I noticed some tests that failed because of the pr. |
The test needs to be re-run. It looks like my change didn't get pulled into the test. But the test says line 24: Edit: Tests pass now. The failing library collection tests are fixed with #606. |
Nice work! 👍 the only thing I think we should improve the the doc string of the kwargs. I think we should mention why this can be usefull as we have got questions about speed and reloads before. I’m gonna leave this open for a day so others have had the time to chip in before I merge |
* Allows includes to be used by Audio, Video, Photoalbum, Photo, Collections, and Playlist
JonnyWong16
commented
Nov 22, 2020
Refactored the includes to Doc string for |
Hellowlol
commented
Nov 22, 2020
Is the include the same for all the classes? |
JonnyWong16
commented
Nov 22, 2020
Most of them are the same when you view them through Plex Web. Some might be extra (e.g. for Playlists) but it doesn't affect the response from the server. |
b8e1739 to
688049dCompare688049d to
7f7d032Compare…m_includes Add ability to customize XML includes when reloading object
Description
Add ability to customize XML includes when reloading a
PlexObject._details_keyalways has all the includes.reload(checkFiles=False)) will remain as a partial object.reload()will have all includes so it will be a full object (existing behaviour maintained).The only potential breaking change is objects that used to have a blank
_details_key = ''now have a populated_details_key = key. I don't think this should cause any issues because the_details_keyis only used when reloading and it checks for the_details_key or keyso it makes no difference if they are now equal.Fixes#603
Conflicts with #590 (the
_includesparameters were refactored)Requires #606 (
isFullObject()needs to check the_details_keyinstead ofkey)TODO: Tests need to be added for reloading with includes disabled.Type of change
Please delete options that are not relevant.
Checklist: