Skip to content

Handle missing key when PlayQueue passed to playMedia - #692

Merged
jjlawren merged 2 commits into
pushingkarmaorg:masterfrom
jjlawren:playmedia_missing_key
Mar 11, 2021
Merged

Handle missing key when PlayQueue passed to playMedia#692
jjlawren merged 2 commits into
pushingkarmaorg:masterfrom
jjlawren:playmedia_missing_key

Conversation

@jjlawren

Copy link
Copy Markdown
Collaborator

If a PlayQueue object is passed to PlexClient.playMedia(), the generated key argument used in the resulting call is always None. This uses the currently selected item from the PlayQueue in that case.

@jjlawren

Copy link
Copy Markdown
CollaboratorAuthor

An alternative that's less explicit but far simpler: jjlawren@bb7b959

@jjlawren

Copy link
Copy Markdown
CollaboratorAuthor

The key value has been sending None to clients for years when a premade playqueue is passed in, but most seem to handle it gracefully and play anyway. Others like the 3rd party Samsung TV "Orca" client do not and throw up an error.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@jjlawren