Skip to content

Add Themes Support - #879

Merged
JonnyWong16 merged 7 commits into
pushingkarmaorg:masterfrom
ReenigneArcher:themes
Feb 27, 2022
Merged

Add Themes Support#879
JonnyWong16 merged 7 commits into
pushingkarmaorg:masterfrom
ReenigneArcher:themes

Conversation

@ReenigneArcher

@ReenigneArcherReenigneArcher commented Jan 25, 2022

Copy link
Copy Markdown
Contributor

Description

Please include a summary of the change and which issue is fixed.

  • Closely replicates Poster Mixins for Themes
    • list themes
    • upload theme
    • set theme
    • get theme url with token
  • Add Theme attribute for movies in video.py
  • Fixes typo in PosterUrlMixin class (grandparentThumb)
  • Replaces Add ability to upload theme music #658

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@ReenigneArcher

ReenigneArcher commented Jan 25, 2022

Copy link
Copy Markdown
ContributorAuthor

Again, I understand if you don't want to merge this due to not being able to easily delete the Themes. Either way, this is a cleaner version of #658 .

@ReenigneArcherReenigneArcher mentioned this pull request Jan 25, 2022
Closed
@JonnyWong16

JonnyWong16 commented Jan 25, 2022

Copy link
Copy Markdown
Collaborator

Can you separate this into a new bugfix PR?

  • Fixes typo in PosterUrlMixin class (grandparentThumb)

JonnyWong16
JonnyWong16 requested changes Jan 25, 2022
View reviewed changes

@JonnyWong16JonnyWong16 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collection can also have ThemeMixin.

Comment threadplexapi/video.py Outdated
Comment threadplexapi/video.py Outdated
Comment threadplexapi/audio.py Outdated
Comment threadplexapi/audio.py Outdated
Comment threadplexapi/audio.py Outdated
Comment threadplexapi/mixins.py Outdated
Comment threadplexapi/media.py Outdated
@ReenigneArcher

ReenigneArcher commented Jan 26, 2022

Copy link
Copy Markdown
ContributorAuthor

Can you separate this into a new bugfix PR?

* Fixes typo in PosterUrlMixin class (`grandparentThumb`)

Do I also need to revert that change in this branch?

@JonnyWong16

JonnyWong16 commented Jan 26, 2022

Copy link
Copy Markdown
Collaborator

Do I also need to revert that change in this branch?

No, leave it for now and rebase after #880.

JonnyWong16
JonnyWong16 requested changes Jan 26, 2022
View reviewed changes
Comment threadplexapi/media.py Outdated
Comment threadplexapi/media.py Outdated
@JonnyWong16
JonnyWong16 merged commit 9a5170c into pushingkarmaorg:masterFeb 27, 2022
@JonnyWong16JonnyWong16 mentioned this pull request Feb 27, 2022
Merged
9 tasks
@ReenigneArcher
ReenigneArcher deleted the themes branch January 19, 2023 20:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonnyWong16JonnyWong16JonnyWong16 approved these changes

Assignees

No one assigned

Labels

non-breaking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ReenigneArcher@JonnyWong16