Update detect_clearsky( ) by eccoope · Pull Request #1708 · pvlib/pvlib-python

eccoope · 2023-03-24T20:37:51Z

ClosesSupport for unequal time intervals #1678
I am familiar with the contributing guidelines
Tests added
Updates entries in docs/sphinx/source/reference for API changes.
Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
Pull request is nearly complete and ready for detailed review.
Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Modified algorithm in detect_clearsky( ) to support missing timestamps (in a DatetimeIndex of evenly spaced intervals). Supporting functions were also modified to accommodate this change.

…into cs_branch

@cwhanse

from @cwhanse Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>

…into cs_branch

mikofski · 2023-04-17T22:39:02Z

Would it be possible to run the detect_clearsky benchmarks with and without this PR on the same machine for comparison?

eccoope · 2023-04-18T20:12:28Z

Would it be possible to run the detect_clearsky benchmarks with and without this PR on the same machine for comparison?

Yes - just did this on my local machine. The old function takes 0.4933785000030184 seconds to run 10 times and the version in the PR takes 0.9015975999936927 seconds to do the same.

…orked into cs_branch

cwhanse

IMO the performance hit is worth the enhancement of handling missing timesteps.

cwhanse · 2023-06-20T16:42:41Z

+ points are equal except in the case that data is missing.
 """

 if times is None:


I feel like this if and try should move down and use ispandas, optional cleanup.

cwhanse · 2023-06-20T16:44:57Z

+ # arrays of different lengths when evaluating comparison criteria and
+ # when indexing the Hankel matrix to construct clear_samples
+ elif len(clear_sky.index) != len(times):
+ clear = pd.Series(clear_sky, index=times)


Untested, and I suspect this will fail - clear_sky is a Series of different length than times so it can't get indexed by times.

Just added a test for this in test_clearsky.py

Changed clear_sky back to clearsky

Import DATA_DIR

cwhanse · 2023-07-24T16:06:38Z

 import pandas as pd
 import pytz
 import warnings
+from .conftest import DATA_DIR


This line should be test_tools, that will fix the doc build error.

Thanks @cwhanse !

Move import statement to test_tools.py pt1

Move import statement to test_tools.py pt2

AdamRJensen · 2025-10-23T20:43:30Z

@cwhanse is this still be worked on from Sandias side?

cwhanse · 2025-10-23T21:02:17Z

@cwhanse is this still be worked on from Sandias side?

Let me talk a look at it. I had forgotten.

eccoopeand others added 11 commits March 7, 2023 14:12

''
89034a1

''
403c798

''
a657310

''
a9fdfcd

'Supporting_missing_timesteps_in_detect_clearsky()'
f3db8d3

Merge branch 'main' ofhttps://github.com/eccoope/pvlib-python-forked…
7121215
…into cs_branch

Merge branch 'main' ofhttps://github.com/eccoope/pvlib-python-forked…
fd0f0c0
…into cs_branch

stickler changes
3e2ea1f

stickler
664bfae

stickler changes
2acfd40

'Fixed_unit_test'
d29c7de

cwhanse added the enhancement label Mar 29, 2023

cwhanse modified the milestones: 0.9.6, 0.9.5 Mar 29, 2023

cwhanse reviewed Mar 29, 2023
View reviewed changes

Comment threadpvlib/clearsky.py Outdated
Comment threadpvlib/clearsky.py Outdated
Comment threadpvlib/clearsky.py Outdated
Comment threadpvlib/clearsky.py Outdated
Comment threadpvlib/tests/test_tools.py Outdated

eccoopeand others added 5 commits March 29, 2023 13:19

Apply suggestions from code review
97e53d0
from @cwhanse Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>

'modified_to_preserve_nans'
e8e5faa

Merge branch 'pvlib:main' into cs_branch
386b260

Merge branch 'main' ofhttps://github.com/eccoope/pvlib-python-forked…
2110d67
…into cs_branch

'modified_to_preserve_nans'
d4d1187

eccoopeand others added 2 commits April 18, 2023 13:37

'added_tests_for_data_with_nans_for_detect_clearsk'y
92cb84b

fixed relative import statements
bd33436

eccoopeand others added 3 commits April 20, 2023 16:02

updated whatsnew file and included data for test_clearsky.py
710c056

Merge branch 'cs_branch' ofhttps://github.com/eccoope/pvlib-python-f…
dea6d00
…orked into cs_branch

Stickler corrections
868e45b

Stickler
f5e1fbc

kandersolar modified the milestones: 0.9.6, 0.10.0 May 16, 2023

kandersolar mentioned this pull request May 16, 2023
v0.10.0 release plan #1735
Closed

cwhanse approved these changes Jun 20, 2023
View reviewed changes

kandersolar reviewed Jun 21, 2023
View reviewed changes

Comment threadpvlib/clearsky.py

eccoopeand others added 3 commits June 21, 2023 11:25

Added tests for if/else clause in detect_clearsky()
9385702

Update clearsky.py
9d5d0cb
Changed clear_sky back to clearsky

Merge branch 'main' into cs_branch
61490bf

kandersolar modified the milestones: 0.10.0, v0.10.2 Jul 6, 2023

eccoope added 4 commits July 10, 2023 14:19

Delete v0.9.6.rst
cc36315

Merge branch 'main' into cs_branch
f4ff62b

Update tools.py
3c29c99
Import DATA_DIR

Merge branch 'pvlib:main' into cs_branch
806e46a

cwhanse reviewed Jul 24, 2023
View reviewed changes

eccoope added 2 commits July 24, 2023 11:10

Update tools.py
0021e1d
Move import statement to test_tools.py pt1

Update test_tools.py
ecf2bbf
Move import statement to test_tools.py pt2

kandersolar mentioned this pull request Sep 6, 2023
v0.10.2 release planning #1848
Closed

kandersolar modified the milestones: v0.10.2, v0.10.3 Sep 21, 2023

Merge branch 'pvlib:main' into cs_branch
ae0b2c7

kandersolar modified the milestones: v0.10.3, v0.10.4 Dec 20, 2023

kandersolar mentioned this pull request Mar 12, 2024
v0.10.4 release planning #1992
Closed

kandersolar modified the milestones: v0.10.4, Someday Mar 18, 2024

RDaxini mentioned this pull request Sep 26, 2024
v0.11.1 release plan #2220
Closed
11 tasks

Uh oh!

Conversation

eccoope commented Mar 24, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mikofski commented Apr 17, 2023

Uh oh!

eccoope commented Apr 18, 2023

Uh oh!

cwhanse left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cwhanseJun 20, 2023

Choose a reason for hiding this comment

Uh oh!

cwhanseJun 20, 2023

Choose a reason for hiding this comment

Uh oh!

eccoopeJun 21, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cwhanseJul 24, 2023

Choose a reason for hiding this comment

Uh oh!

eccoopeJul 24, 2023

Choose a reason for hiding this comment

Uh oh!

AdamRJensen commented Oct 23, 2025

Uh oh!

cwhanse commented Oct 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

eccoope commented Mar 24, 2023•
edited
Loading