Skip to content

Debug Builds: -DPy_DEBUG - #1438

Merged
wjakob merged 1 commit into
pybind:masterfrom
ax3l:fix-pyDebugLibs
Aug 29, 2018
Merged

Debug Builds: -DPy_DEBUG#1438
wjakob merged 1 commit into
pybind:masterfrom
ax3l:fix-pyDebugLibs

Conversation

@ax3l

@ax3lax3l commented Jun 24, 2018

Copy link
Copy Markdown
Collaborator

builds against a python debug library were unreliable and could lead to symbol errors during linking.

Setting the Py_DEBUG define is necessary when linking against a debug build:

https://stackoverflow.com/questions/39161202/how-to-work-around-missing-pymodule-create2-in-amd64-win-python35-d-lib

https://docs.python.org/2/c-api/intro.html#debugging-builds

https://docs.python.org/3.6/c-api/intro.html#debugging-builds

First seen in PR #1416

@ax3lax3l mentioned this pull request Jun 24, 2018
builds against a python debug library were unreliable and
could lead to symbol errors during linking.
Setting the `Py_DEBUG` define is necessary when linking
against a debug build:
https://stackoverflow.com/questions/39161202/how-to-work-around-missing-pymodule-create2-in-amd64-win-python35-d-libhttps://docs.python.org/2/c-api/intro.html#debugging-buildshttps://docs.python.org/3.6/c-api/intro.html#debugging-builds
@ax3l

ax3l commented Aug 8, 2018

Copy link
Copy Markdown
CollaboratorAuthor

@wjakob@jagerman this PR fixes failing debug builds where the wrong Python ABI is selected. Can you please take a look?

@ax3l

ax3l commented Aug 29, 2018

Copy link
Copy Markdown
CollaboratorAuthor

@wjakob do you mind merging this as well? :)

@wjakob

Copy link
Copy Markdown
Member

Yeah, sorry about the delay.

@wjakob
wjakob merged commit 3a94561 into pybind:masterAug 29, 2018
@ax3l
ax3l deleted the fix-pyDebugLibs branch August 29, 2018 11:22
@ax3l

ax3l commented Aug 29, 2018

Copy link
Copy Markdown
CollaboratorAuthor

no prob, thanks a lot!

@ax3lax3l mentioned this pull request Sep 4, 2018
wjakob pushed a commit that referenced this pull request Sep 11, 2018
builds against a python debug library were unreliable and
could lead to symbol errors during linking.
Setting the `Py_DEBUG` define is necessary when linking
against a debug build:
https://stackoverflow.com/questions/39161202/how-to-work-around-missing-pymodule-create2-in-amd64-win-python35-d-libhttps://docs.python.org/2/c-api/intro.html#debugging-buildshttps://docs.python.org/3.6/c-api/intro.html#debugging-builds
@rwgkrwgk mentioned this pull request Feb 9, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ax3l@wjakob