Uh oh!
There was an error while loading. Please reload this page.
Enable dynamic attribute support for Pypy >= 6 - #1494
Conversation
I'm hesitant to merge this if there is no test coverage. Would you mind adding a PyPy 6.x configuration to Travis? |
Done. It does not pass, but the failures look largely unrelated to the change I made: |
bstaletic
commented
Aug 29, 2018
Rebase onto master. The failure was fixed last night. |
inducer
commented
Aug 29, 2018
Thanks for taking a look. Still failing, with much the same failures: |
wjakob
commented
Sep 11, 2018
hm :-| -- any thoughts on what the deal is with the other PyPy issue? |
inducer
commented
Sep 11, 2018
No clue, sorry. |
Do you have any actual reference that PyPy 6 has this enabled? |
wjakob
commented
Sep 19, 2018
Not sure I understand, what does "this" refer to in your sentence? Attribute support? |
xuhdev
commented
Sep 19, 2018
@wjakob Yes... sorry for the confusion. |
Adapted from pybind#1494
Adapted from pybind#1494
Adapted from pybind#1494
rwgk
commented
Jun 18, 2020
Hi Andreas, there was a recent upgrade to use PyPy 7.3 on travis, e.g. here is a random recent result (bottom of page): https://travis-ci.org/github/pybind/pybind11/builds/698654908 |
lopuhin
commented
Jun 18, 2020
@rwgk I think this PR is still relevant and now it seems closer to merging (after travis changes are removed), as these changes https://github.com/pybind/pybind11/pull/1494/files#diff-cb87ad4a7288c536c9adc5a5694134ca still look relevant to me. |
inducer
commented
Jun 18, 2020
wjakob
commented
Jun 30, 2020
It will be merged soon, I will close this PR then. |
According to my experiments, the code that's disabled by the conditional on Pypy appears to work just fine on (at least) Pypy 6.0.