Uh oh!
There was an error while loading. Please reload this page.
fix: allow lto to be off in CMake 3.9+ - #2347
Closed
henryiii wants to merge 2 commits into
Closed
Conversation
henryiii
commented
Jul 31, 2020
CollaboratorAuthor
By the way, I could respect this being set to OFF even before 3.9, to have a universal way to turn it off in emergencies. |
henryiii
marked this pull request as draft
August 5, 2020 18:39
henryiii
commented
Aug 5, 2020
CollaboratorAuthor
I'm going to have to address this in a slightly different way - will either be part of the FindPython work or added just after it. |
henryiii
commented
Aug 8, 2020
CollaboratorAuthor
PR #2370 does this in a slightly different way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
CMAKE_INTERPROCEDURAL_OPTIMIZATIONis defined toOFF, respect that (CMake 3.9+). Closes#1415.