Skip to content

fix: some build-system cleanup - #2368

Merged
henryiii merged 5 commits into
pybind:masterfrom
henryiii:tests/pclean
Aug 6, 2020
Merged

fix: some build-system cleanup#2368
henryiii merged 5 commits into
pybind:masterfrom
henryiii:tests/pclean

Conversation

@henryiii

@henryiiihenryiii commented Aug 6, 2020•
edited
Loading

Copy link
Copy Markdown
Collaborator

Taking the unrelated changes from #2353 to see if that can go in stand alone.

  • Some cleanup of CMakeLists
  • Make all target names unique
  • Include .cmake.in files when formatting
  • Update CI to do more testing (shorten Configure to Config, too)
  • PYBIND11_CPP_STANDARD was not being handled correctly, now it does what I claimed it did before

@henryiiihenryiii changed the title fix: partial cleanupfix: some build-system cleanupAug 6, 2020
rwgk
rwgk approved these changes Aug 6, 2020
View reviewed changes

@rwgkrwgk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big Thank You Henry!

Comment threadtests/test_cmake_build/subdirectory_target/CMakeLists.txt
@henryiii
henryiii merged commit 227170d into pybind:masterAug 6, 2020
@henryiii
henryiii deleted the tests/pclean branch August 6, 2020 15:54
@MonkeyBreakerMonkeyBreaker mentioned this pull request Aug 8, 2020
Closed
@rwgkrwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgkrwgkrwgk approved these changes

Assignees

No one assigned

Labels

build system

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@henryiii@rwgk