Uh oh!
There was an error while loading. Please reload this page.
tests: cleanup and ci hardening - #2397
Conversation
3d37b12 to
ec86a98CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
I believe 7 or so tests are now passing in PyPy that used to fail (and were hidden by skip instead of xfail), mostly due to better NumPy support in recent PyPy's. |
Uh oh!
There was an error while loading. Please reload this page.
That's great to hear! :-) |
henryiii
commented
Aug 16, 2020
If I get two approvals, I'll squash and merge. :) |
bstaletic
left a comment
There was a problem hiding this comment.
This looks great. Thanks for the PR.
Refactor the tests. Use a consistent failing/skipping scheme.
Skips/xfails are more consistent, no more
pytest.bug_in_pypy,pytest.unsupported_on_pypy_lt_6, etc. (PyPy 7+ required, so ignoring check for old PyPy verisions). No more injection into the pytest module. xfails are reported at the end and most are strictly required. We can usereasonsorraisesto improve the test reporting.