Uh oh!
There was an error while loading. Please reload this page.
fix: use OVERRIDE instead of OVERLOAD - #2490
Conversation
YannickJadoul
left a comment
There was a problem hiding this comment.
Looks good to me! :-)
henryiii
commented
Sep 15, 2020
Okay, one of us can merge when tests pass. ;) |
YannickJadoul
commented
Sep 15, 2020
Thanks for the docs fix! |
NickAlger
commented
Oct 26, 2020
FYI, the default version installed using conda still uses OVERLOAD. At present, anyone who installs pybind11 via conda will get an error when they try to follow this tutorial (this happened to me, leading to several hours of confusion before I found this thread) |
YannickJadoul
commented
Oct 26, 2020
@NickAlger, what's the version you get from conda, then? |
YannickJadoul
commented
Oct 26, 2020
@NickAlger, I downloaded a random package from here, and it does contain the correct 2.6.0 files. Now I'm very curious where you got your version. |
NickAlger
commented
Oct 26, 2020
@YannickJadoul Looks like 2.4.3, installed 3 days ago via |
YannickJadoul
commented
Oct 26, 2020
@NickAlger, that's quite horrible; quite a few things have been improved since 2.4.3. Anyway, thanks for looking into that! :-) |
@YannickJadoul, I undid a few changes from #2325 in #2478 due to a bad rebase (I had the change backwards for some reason). This should fix it, I think.