Skip to content

tests: Fix test override execution - #2512

Merged
henryiii merged 1 commit into
pybind:masterfrom
EricCousineau-TRI:feature-test-override-fix
Sep 22, 2020
Merged

tests: Fix test override execution#2512
henryiii merged 1 commit into
pybind:masterfrom
EricCousineau-TRI:feature-test-override-fix

Conversation

@EricCousineau-TRI

Copy link
Copy Markdown
Collaborator

Hotfix for #2353

Ran into this when trying to add a quick test on upstream.

@EricCousineau-TRI

EricCousineau-TRI commented Sep 19, 2020

Copy link
Copy Markdown
CollaboratorAuthor

Er, from looking closer, seems like current master should work. Perhaps I did something wrong. Will try a few more times.

@EricCousineau-TRI

EricCousineau-TRI commented Sep 19, 2020

Copy link
Copy Markdown
CollaboratorAuthor

K, updated (via force push).

Two things:

  • The replacement output to PYBIND11_BINARY_TEST_FILES, but then code below consumed PYBIND11_BINARY_PYTEST_FILES (missing PY)
  • The replacement basically tells pytest to read the Python files from the binary dir, but it should've been the src dir.

@bstaleticbstaletic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess @henryiii should have the final word, but this makes sense.

@henryiii

Copy link
Copy Markdown
Collaborator

Looks good to me! Thanks!

@henryiii
henryiii merged commit d74be32 into pybind:masterSep 22, 2020
@EricCousineau-TRI

Copy link
Copy Markdown
CollaboratorAuthor

Thanks!

@rwgkrwgk mentioned this pull request Feb 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@EricCousineau-TRI@henryiii@bstaletic