Skip to content

fix: install to DATAROOTDIR instead of hardcoding share - #2584

Merged
henryiii merged 1 commit into
pybind:masterfrom
henryiii:fix/cmake_configdir
Oct 13, 2020
Merged

fix: install to DATAROOTDIR instead of hardcoding share#2584
henryiii merged 1 commit into
pybind:masterfrom
henryiii:fix/cmake_configdir

Conversation

@henryiii

Copy link
Copy Markdown
Collaborator

Closes#2571; this is defined to share, and unlike DATADIR, is not sometimes overwritten incorrectly for storing CMake files.

Closespybind#2571; this is defined to share, and unlike DATADIR, is not sometimes overwritten incorrectly for storing CMake files.
@henryiiihenryiii added this to the v2.6.0 milestone Oct 13, 2020
@henryiii

Copy link
Copy Markdown
CollaboratorAuthor

I don't see any reason this can't go into 2.6.0, as it's just defined to share. This is useful for cross-compiling, as it can be set manually by toolchains. It also should correctly support installing to / if someone wanted to do that, as all GNU paths get usr added.

@henryiii
henryiii merged commit edda89b into pybind:masterOct 13, 2020
@henryiii
henryiii deleted the fix/cmake_configdir branch October 13, 2020 17:08
@rwgkrwgk mentioned this pull request Feb 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[QUESTION] Why is GNUInstallDirs not used in CMakeLists.txt?

1 participant

@henryiii