Uh oh!
There was an error while loading. Please reload this page.
enum: Add Enum.value property - #2739
Conversation
e5010de to
f3f32b6CompareUh oh!
There was an error while loading. Please reload this page.
EDIT: Moved here: #2332 (comment) |
Er, also - I shoulda put that design comment in the issue. EDIT: Done. |
EricCousineau-TRI
commented
Dec 31, 2020
@bstaletic Any chance you got a brief few min to approve the latest changes here? |
bstaletic
left a comment
There was a problem hiding this comment.
Sorry for the delay. This looks perfectly fine.
YannickJadoul
left a comment
There was a problem hiding this comment.
Looks good! Thanks, @EricCousineau-TRI!
Are you also planning to tackle the __iter__ part of #2332?
YannickJadoul
commented
Dec 31, 2020
Let's see if this still makes it into 2.6.2? I guess it could conflict with users' code when they already defined |
YannickJadoul
commented
Dec 31, 2020
EricCousineau-TRI
commented
Dec 31, 2020
Hopefully it's sufficiently benign! It does modify the class defined by My vote is, onwards! It cool if I merge?! 😬 |
YannickJadoul
commented
Dec 31, 2020
As far as I'm concerned, yes :-) Should we quickly check with @henryiii on the 2.6.2 thing; he's been unofficially managing the last few releases? |
EricCousineau-TRI
commented
Dec 31, 2020
Sounds good! Henry, you cool with pushing the merge button on this one? |
henryiii
commented
Dec 31, 2020
I've edited the changelog a bit to make it sound a bit more like a patch-worthy addition. ;) |
YannickJadoul
commented
Dec 31, 2020
Thanks for picking this up, @EricCousineau-TRI! |
EricCousineau-TRI
commented
Dec 31, 2020
Sweet, thank y'all for reviewing 'n merging! |
Description
Towards #2332 - adds a
.valueattributeSuggested changelog entry: