Uh oh!
There was an error while loading. Please reload this page.
CI: Intel icx/icpx via oneAPI - #2769
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
New compiler, all green, within 24h? Is this possible, or am I dreaming? EDIT: Oh... no. Somehow, the CI workflow hasn't even run :-( |
henryiii
commented
Jan 7, 2021
Yaml must be invalid? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
c76931a to
eb1c683CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
henryiii
commented
Jan 14, 2021
@ax3l The issue now is in the CMake config to force it to recognize icpx. |
Uh oh!
There was an error while loading. Please reload this page.
ax3l
left a comment
There was a problem hiding this comment.
Potential these two are also needed:
Fix compiler detection that made it into the CMake shipped with oneAPI. This is already fixed in CMake upstream.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
c8c0708 to
b6d72e1CompareUh oh!
There was an error while loading. Please reload this page.
| -DCMAKE_CXX_COMPILER_VERSION=12.0 \ | ||
| -DCMAKE_CXX_STANDARD_COMPUTED_DEFAULT="14" \ | ||
| -DCMAKE_VERBOSE_MAKEFILE=ON \ | ||
| -DPYTHON_EXECUTABLE=$(python3 -c "import sys; print(sys.executable)") |
There was a problem hiding this comment.
Is this actually preferred over $(which python3)?
There was a problem hiding this comment.
This works on bash for Windows or something like that, I don't remember exactly why. Pretty sure it had to do with portability somehow. which should be just fine for this sort of thing on linux for sure.
henryiii
commented
Jan 16, 2021
I am making vectorize a bit easier to compile in #2729 - don't know why it's compiling but not working here. |
What is this identifying as, I wonder? Does it define the intel macros? Clang macros? Both? Neither? |
Oh that's a bug that slipped into CMake It's reverted now and complete IntelLLVM and SYCL/DPC++ support is being worked on:
So if we leave this open until the next oneAPI release comes out and ships CMake 3.20+ (usually a month max.) then we should be able to remove the work-around of the compiler detection. |
Uh oh!
There was an error while loading. Please reload this page.
Once we have Likely an upstream Intel issue, but we'll see. |
4330516 to
c2512eeCompare6788039 to
9ef16dcCompareAdd testing for Intel icx/icpx via the oneAPI images. This is Intel's next-gen compiler and new C++ support, e.g. C++17 bug fixes, first land here. Update .github/workflows/ci.yml Co-authored-by: Yannick Jadoul <yannick.jadoul@belgacom.net> CMake: Fix ICPX Detection in Python tests More IntelClang Detection Upsi, keep ICC rebased out by accident Prettify Compiler Workaround: Just in Configure ci: rely on newer CMake
Yay, made some progress. Now we have a few tests that fail the vectorization tests. test_vectorizetest_vectorized_noreturn |
Add testing for Intel icx/icpx via the oneAPI images.
This is Intel's next-gen compiler and new C++ support, e.g. C++17 bug fixes, first land here.
For the Intel "classic" compilers icc/icpc, please see #2573