Skip to content

fix: STATIC and SHARED flags not being detected - #2796

Merged
YannickJadoul merged 2 commits into
pybind:masterfrom
heyer2:patch-1
Jan 14, 2021
Merged

fix: STATIC and SHARED flags not being detected#2796
YannickJadoul merged 2 commits into
pybind:masterfrom
heyer2:patch-1

Conversation

@heyer2

@heyer2heyer2 commented Jan 14, 2021•
edited by henryiii
Loading

Copy link
Copy Markdown
Contributor

I noticed SHARED and STATIC flags no longer being respected after updating pybind11. This fixes it.

Suggested changelog entry:

* Fix ``STATIC`` / ``SHARED`` being ignored in FindPython mode.

@henryiiihenryiii added this to the v2.6.2 milestone Jan 14, 2021
@henryiiihenryiii changed the title Fix STATIC and SHARED flags not being detectedfix: STATIC and SHARED flags not being detectedJan 14, 2021
@henryiii

henryiii commented Jan 14, 2021

Copy link
Copy Markdown
Collaborator

This only fixes the new FindPython, assuming there is nothing wrong with the classic version?

@heyer2

heyer2 commented Jan 14, 2021

Copy link
Copy Markdown
ContributorAuthor

Classic one seems fine to me.

@YannickJadoul

YannickJadoul commented Jan 14, 2021

Copy link
Copy Markdown
Collaborator

Thanks, @heyer2!

@YannickJadoul
YannickJadoul merged commit 76a1600 into pybind:masterJan 14, 2021
@github-actionsgithub-actionsBot added the needs changelog Possibly needs a changelog entry label Jan 14, 2021
@henryiiihenryiii removed the needs changelog Possibly needs a changelog entry label Jan 25, 2021
@henryiiihenryiii mentioned this pull request Jan 26, 2021
Merged
@rwgkrwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henryiiihenryiiihenryiii approved these changes
@YannickJadoulYannickJadoulYannickJadoul approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.6.2

Development

Successfully merging this pull request may close these issues.

3 participants

@heyer2@henryiii@YannickJadoul