Skip to content

Changing PYBIND11_SMART_HOLDER_TYPE_CASTERS to use __VA_ARGS__. - #2954

Merged
rwgk merged 1 commit into
pybind:smart_holderfrom
rwgk:shtc_va_args
Apr 15, 2021
Merged

Changing PYBIND11_SMART_HOLDER_TYPE_CASTERS to use __VA_ARGS__.#2954
rwgk merged 1 commit into
pybind:smart_holderfrom
rwgk:shtc_va_args

Conversation

@rwgk

@rwgkrwgk commented Apr 15, 2021

Copy link
Copy Markdown
Collaborator

No description provided.

@rwgk

rwgk commented Apr 15, 2021

Copy link
Copy Markdown
CollaboratorAuthor

The CI is green, also with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT (#2879). This change will get reviewed Google-internally. Merging. I'll open a new PR if there are requests for changes.

@rwgk
rwgk merged commit 1c8795a into pybind:smart_holderApr 15, 2021
@rwgk
rwgk deleted the shtc_va_args branch April 15, 2021 17:33
@github-actionsgithub-actionsBot added the needs changelog Possibly needs a changelog entry label Apr 15, 2021
@rwgkrwgk removed the needs changelog Possibly needs a changelog entry label Apr 15, 2021
@EricCousineau-TRIEricCousineau-TRI added the smart holder See: https://github.com/pybind/pybind11/blob/smart_holder/README_smart_holder.rst label Apr 26, 2021
@rwgkrwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

smart holderSee: https://github.com/pybind/pybind11/blob/smart_holder/README_smart_holder.rst

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rwgk@EricCousineau-TRI