Skip to content

use CMAKE_INSTALL_FULL_INCLUDEDIR - #3005

Merged
henryiii merged 1 commit into
pybind:masterfrom
dotlambda:patch-1
Jun 19, 2021
Merged

use CMAKE_INSTALL_FULL_INCLUDEDIR#3005
henryiii merged 1 commit into
pybind:masterfrom
dotlambda:patch-1

Conversation

@dotlambda

@dotlambdadotlambda commented May 14, 2021•
edited by henryiii
Loading

Copy link
Copy Markdown
Contributor

Description

see https://github.com/jtojnar/cmake-snips#assuming-cmake_install_dir-is-relative-path

Suggested changelog entry:

Fix ``pybind11_INCLUDE_DIR`` in case ``CMAKE_INSTALL_INCLUDEDIR`` is absolute

@dotlambda
dotlambda requested a review from henryiii as a code ownerMay 14, 2021 11:03
henryiii
henryiii approved these changes Jun 19, 2021
View reviewed changes

@henryiiihenryiii left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me, and it available at least since 3.4 (only one I checked). Might need to look over that list and update https://cliutils.gitlab.io/modern-cmake/ .

@henryiii
henryiii merged commit d00fc62 into pybind:masterJun 19, 2021
@github-actionsgithub-actionsBot added the needs changelog Possibly needs a changelog entry label Jun 19, 2021
@dotlambda
dotlambda deleted the patch-1 branch June 20, 2021 09:35
@henryiiihenryiii removed the needs changelog Possibly needs a changelog entry label Jul 13, 2021
This was referenced Jul 26, 2021
Closed
Merged
@rwgkrwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henryiiihenryiiihenryiii approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dotlambda@henryiii