Uh oh!
There was an error while loading. Please reload this page.
Removing std::get_deleterconst_cast. - #3045
Merged
rwgk merged 1 commit intoJun 17, 2021
Merged
Conversation
…as changed significantly.
std::get_deleterconst_cast.std::get_deleterconst_cast.rwgk
marked this pull request as ready for review
June 17, 2021 20:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to PR #3041.
It was a small surprise that retesting here showed that the
const_castis not needed. Evidently I got confused by a CI failure (under PR #3023, which was and is still a work in progress) for some intermediate state in the development that lead to PR #3041. Details omitted: I don't think it's worth anyone's time.