Uh oh!
There was an error while loading. Please reload this page.
Removing MSVC C4522 from pragma block at the top of pybind11.h - #3142
Merged
Conversation
rwgk
marked this pull request as ready for review
July 26, 2021 17:54
rwgkforce-pushed
the
pragma_block_rm_msvc_c4522
branch
from
July 26, 2021 18:33
ef106c8 to
a799fcdComparehenryiii
approved these changes
Jul 26, 2021
henryiii
left a comment
Collaborator
There was a problem hiding this comment.
This is a weird warning...
rwgk
commented
Jul 26, 2021
CollaboratorAuthor
Yeah, the fact that it went away with MSVC 2019 makes me think the warning was more of a bug than a feature. Thanks Henry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to PR #3127, based on results obtained under PR #3125.
The suggested changelog entry will be in the final PR of this cleanup series.