Skip to content

Removing MSVC C4100 from pragma block at the top of pybind11.h - #3150

Merged
rwgk merged 8 commits into
pybind:masterfrom
rwgk:pragma_block_rm_msvc_c4100
Jul 29, 2021
Merged

Removing MSVC C4100 from pragma block at the top of pybind11.h#3150
rwgk merged 8 commits into
pybind:masterfrom
rwgk:pragma_block_rm_msvc_c4100

Conversation

@rwgk

@rwgkrwgk commented Jul 28, 2021•
edited
Loading

Copy link
Copy Markdown
Collaborator

Follow-on to PR #3127, based on results obtained under PR #3125.

The suggested changelog entry will be in the final PR of this cleanup series.

Worksheet

@rwgk
rwgkforce-pushed the pragma_block_rm_msvc_c4100 branch from e89b2ec to 85dd61cCompareJuly 28, 2021 16:00
@rwgkrwgk changed the title Pragma block rm msvc c4100Removing MSVC C4100 from pragma block at the top of pybind11.hJul 28, 2021
@rwgk
rwgk marked this pull request as ready for review July 28, 2021 18:06
@rwgk
rwgk requested review from Skylion007 and henryiiiJuly 28, 2021 18:06
henryiii
henryiii reviewed Jul 28, 2021
View reviewed changes
Comment threadinclude/pybind11/detail/common.h
henryiii
henryiii reviewed Jul 28, 2021
View reviewed changes
Comment threadinclude/pybind11/attr.h
@rwgk

rwgk commented Jul 29, 2021

Copy link
Copy Markdown
CollaboratorAuthor

Thanks Henry! (Only two more MSVC pragmas to go.)

@rwgk
rwgk merged commit b72ca7d into pybind:masterJul 29, 2021
@rwgk
rwgk deleted the pragma_block_rm_msvc_c4100 branch July 29, 2021 00:01
@github-actionsgithub-actionsBot added the needs changelog Possibly needs a changelog entry label Jul 29, 2021
@rwgkrwgk removed the needs changelog Possibly needs a changelog entry label Jul 29, 2021
rwgk added a commit to rwgk/pybind11 that referenced this pull request Jul 29, 2021
@rwgk
Adding PYBIND11_WORKAROUND_INCORRECT_MSVC_C4100 (follow-on to PRpybi…
bbc4438
…nd#3150).
rwgk added a commit that referenced this pull request Jul 29, 2021
@rwgk
Adding PYBIND11_WORKAROUND_INCORRECT_MSVC_C4100 (follow-on to PR#3150)…
624cd3e
…. (#3154)
@rwgkrwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henryiiihenryiiihenryiii approved these changes
@Skylion007Skylion007Awaiting requested review from Skylion007

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rwgk@henryiii