maint(clang-tidy): Bugprone enable checks

[Skylion007]

Description

• Enables additional clang-tidy checks for bugprone-behavior.

Suggested changelog entry:

* Enable most bugprone checks in clang-tidy and fix the found potential bugs and poor coding styles.

[rwgk]

I just took a super quick look after seeing the emails about your last two commits. Does that mean enable_if isn't needed in this case, just deleting the copy and move constructors does the trick?

[Skylion007]

I just took a super quick look after seeing the emails about your last two commits. Does that mean enable_if isn't needed in this case, just deleting the copy and move constructors does the trick?

Unfortunately, the default copy and move destructors are actually used so I do need to do the enableif trick. It passes clang-tidy but fails compilation.

[Skylion007]

@henryiii Ping. Would appreciated your feedback on this PR. :)

[rwgk]

ICC flaked, I don't remember seeing that exact flake before, but it's download related, it doesn't even get to the configure stage. Maybe just try again?
(I have one suggestion though (I think). Hang on.)

[henryiii]

Looks good, would second @rwgk's suggestions; a couple of places need comments as to why they are doing what they are doing and bugprone-exception-escape is probably less confusing if handled in a different PR (though personally not highly against adding a nolint for it if you know it won't pass, even if it's not enabled, but fine to wait and I do see that seeing a no lint for something that is not being linted is likely quite confusing).

[Skylion007]

@henryiii Need your approval to merge. :)

[rwgk]

Thanks Aaron!

[rwgk]

Looks like you lost a comma in numpy.h.

[rwgk]

@henryiii Need your approval to merge. :)

We are already two maintainers.
This is pure code health.
I don't want to by-pass anyone, but to me this clearly is fine with just one approval.
Note that even in a shop like Google, where you could in theory bring down a service for billions, this is enough approvals coverage. Here we're just working on master codehealth.
Caveat: at Google we cannot submit with a broken CI. But I trust nobody would do that here.