Skip to content

add tests for boost::optional casters - #3332

Closed
Skylion007 wants to merge 22 commits into
pybind:masterfrom
Skylion007:stl_optional_lvalue_fix
Closed

add tests for boost::optional casters#3332
Skylion007 wants to merge 22 commits into
pybind:masterfrom
Skylion007:stl_optional_lvalue_fix

Conversation

@Skylion007

@Skylion007Skylion007 commented Oct 6, 2021•
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

  • Adds tests for boost::optional casters to test suite as well.

Suggested changelog entry:

* Adds tests for boost::optional when compiling pre-C++17 tests.

@Skylion007Skylion007 changed the title (bugfix): Fix STL optional casting issuefix: Fix STL optional casting issueOct 6, 2021
@Skylion007Skylion007 reopened this Oct 8, 2021
@Skylion007Skylion007 reopened this Oct 8, 2021
@Skylion007

Skylion007 commented Oct 8, 2021

Copy link
Copy Markdown
CollaboratorAuthor

@ryancahoon-zoox something like this (although I am running into a bit of trouble backporting nullopt at the moment).

@henryiiihenryiii mentioned this pull request Oct 11, 2021
Closed
3 tasks
@Skylion007Skylion007 changed the title fix: Fix STL optional casting issueadd tests for boost::optional castersOct 11, 2021
@henryiii

henryiii commented Oct 26, 2021

Copy link
Copy Markdown
Collaborator

I think this was included in #3376.

@rwgkrwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgkrwgkAwaiting requested review from rwgk
@henryiiihenryiiiAwaiting requested review from henryiii

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Skylion007@henryiii